erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tpm: spi: Fix compile-time bug with pointer arguments

Browse source 
CL:452283 (tpm: spi: cr50: try to wake cr50 if it is asleep) introduced
a compile-time error by passing an argument the wrong way (probably due
to cherry-picking from an older branch and not testing it again). Due to
a misconfiguration this slipped by our continuous integration testing.
Fix it.

Jeffy, please re-test with this patch on ToT when you have time so we
can make sure the code actually works as intended now, too.

BRANCH=None?
BUG=None
TEST=Compiled GRU_HAS_TPM2 board.

Change-Id: I3210cd53014a206f5d36abcfe607a9710a8253fa
Signed-off-by: Julius Werner <jwerner@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/454921
Reviewed-by: Douglas Anderson <dianders@chromium.org>
This commit is contained in:
Julius Werner 2017-03-14 12:43:48 -07:00
commit 94e01f5e6d
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/drivers/spi/tpm/tpm.c
View file

@ -157,9 +157,9 @@ static int start_transaction(int read_write, size_t bytes, unsigned addr)
tpm_sync_needed = 1;
/* Try to wake cr50 if it is asleep. */
tpm_if.cs_assert(tpm_if.slave);
tpm_if.cs_assert(&tpm_if.slave);
udelay(1);
tpm_if.cs_deassert(tpm_if.slave);
tpm_if.cs_deassert(&tpm_if.slave);
udelay(100);
/*