From 93cef8791b0e58112957e3f5b533bae565c1b83e Mon Sep 17 00:00:00 2001 From: Guangjie Song Date: Tue, 14 Jan 2025 15:01:58 +0800 Subject: [PATCH] soc/mediatek/mt8196: Correct MMinfra vote register Correct MMinfra vote register to fix MMinfra power off failure during suspend. BRANCH=rauru BUG=b:377628718 TEST=Bootup OK and Suspend/Resume OK, with MMinfra kernel/vcp patch, mminfra can be turned off to reduce power consumption by 50mW. Signed-off-by: Guangjie Song Change-Id: I7c23c3c53c68b0de85d8b6189b685de7f8398e8b Reviewed-on: https://review.coreboot.org/c/coreboot/+/86342 Reviewed-by: Yidi Lin Tested-by: build bot (Jenkins) Reviewed-by: Yu-Ping Wu --- src/soc/mediatek/mt8196/mtcmos.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/soc/mediatek/mt8196/mtcmos.c b/src/soc/mediatek/mt8196/mtcmos.c index 367e74b464..e274be8639 100644 --- a/src/soc/mediatek/mt8196/mtcmos.c +++ b/src/soc/mediatek/mt8196/mtcmos.c @@ -42,8 +42,8 @@ #define MMVOTE_MTCMOS_1_CLR ((void *)(MMVOTE_BASE + 0x0224)) #define MMVOTE_MTCMOS_1_DONE ((void *)(MMVOTE_BASE + 0x142C)) #define MMVOTE_MTCMOS_1_PM_ACK ((void *)(MMVOTE_BASE + 0x5518)) -#define MMINFRA_MTCMOS_1_SET ((void *)(MMVOTE_BASE + 0x43220)) -#define MMINFRA_MTCMOS_1_CLR ((void *)(MMVOTE_BASE + 0x43224)) +#define MMINFRA_MTCMOS_1_SET ((void *)(MMVOTE_BASE + 0x20220)) +#define MMINFRA_MTCMOS_1_CLR ((void *)(MMVOTE_BASE + 0x20224)) #define DISP_VDISP_AO_CONFIG_CG 0x3E800108 #define DISP_DPC_DISP0_MTCMOS_CFG 0x3E8F0500