From 93b70934bc97cae82dbbe37577c57154e2f61f4c Mon Sep 17 00:00:00 2001 From: Wenzhen Yu Date: Wed, 12 Feb 2025 17:37:44 +0800 Subject: [PATCH] mb/google/rauru: Notify EC that AP is in S0 GPIO_AP_SUSPEND_L is supposed to be high in S0, and low in S3. EC uses this pin to determine the AP power state. This pin should be set as early as possible in bootblock. BRANCH=rauru TEST=Build pass, reboot pass, suspend/resume pass. BUG=b:395737458 Signed-off-by: Wenzhen Yu Change-Id: I6ea56208256bb6f11fb6b0adf7627403963295bc Reviewed-on: https://review.coreboot.org/c/coreboot/+/86381 Reviewed-by: Yu-Ping Wu Tested-by: build bot (Jenkins) Reviewed-by: Yidi Lin --- src/mainboard/google/rauru/chromeos.c | 1 + src/mainboard/google/rauru/gpio.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mainboard/google/rauru/chromeos.c b/src/mainboard/google/rauru/chromeos.c index b7844b7afb..5196fbe87a 100644 --- a/src/mainboard/google/rauru/chromeos.c +++ b/src/mainboard/google/rauru/chromeos.c @@ -19,6 +19,7 @@ void setup_chromeos_gpios(void) gpio_output(GPIO_EN_SPKR, 0); gpio_output(GPIO_FP_RST_1V8_S3_L, 0); gpio_output(GPIO_XHCI_INIT_DONE, 0); + gpio_output(GPIO_AP_SUSPEND_L, 1); } void fill_lb_gpios(struct lb_gpios *gpios) diff --git a/src/mainboard/google/rauru/gpio.h b/src/mainboard/google/rauru/gpio.h index fd15463a7a..bdbfc2b6ef 100644 --- a/src/mainboard/google/rauru/gpio.h +++ b/src/mainboard/google/rauru/gpio.h @@ -14,6 +14,7 @@ #define GPIO_AP_EC_WARM_RST_REQ GPIO(EINT29) #define GPIO_FP_RST_1V8_S3_L GPIO(EINT26) #define GPIO_AP_FP_FW_UP_STRAP GPIO(EINT27) +#define GPIO_AP_SUSPEND_L GPIO(EINT38) #define GPIO_EN_PWR_FP GPIO(PERIPHERAL_EN3) #define GPIO_BL_PWM_1V8 GPIO(DISP_PWM)