The ABI wrapper from r775 made the SHARED definitions obsolete. They're

not that readable anyway, so kill them and use standard definitions
instead.

Introduce EXPORT_SYMBOL for shared symbols. EXPORT_SYMBOL tells the
compiler to use the standard calling conventions for a given symbol and
not to optimize it away.
Benefits:
- We can later use gcc -combine -fwhole-program without problems.
- It's a correctness fix for some optimizations.
- We could check for duplicated exported functions at link time.
- We could check whether exported functions are linked into initram or
stage2 by accident.
- We could generate usage statistics and possibly optimize away unused
shared functions.
- Through the above points, significant side reductions of 10-40%

Build and boot tested on qemu.
Build tested on all targets.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>


git-svn-id: svn://coreboot.org/repository/coreboot-v3@780 f3766cd6-281f-0410-b1cd-43a5c92072e9
This commit is contained in:
Carl-Daniel Hailfinger 2008-08-17 21:51:13 +00:00
commit 9342d1be4e
9 changed files with 65 additions and 71 deletions

View file

@ -1,8 +1,7 @@
/*
* This file is part of the coreboot project
*
* Copyright(C) 2007 coresystems GmbH
* Written by Stefan Reinauer <stepan@coresystems.de>
* Copyright(C) 2008 Carl-Daniel Hailfinger
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@ -22,41 +21,6 @@
#ifndef SHARED_H
#define SHARED_H
#define FUNC(func, ret, attr, args...) \
ret func(args) attr
#define EXTERN(func, ret, attr, args...)
/**
* Use the SHARED macro to create a universally usable function
* prototype. This will create a function prototype in stage 0 and
* a function prototype plus a function pointer for all code compiled
* with _SHARED defined (required for XIP code)
*
* @func function name
* @ret return value
* @args function arguments
*/
#define SHARED(func,ret,args...) \
FUNC(func,ret,,##args); \
EXTERN(func,ret,,##args)
/**
* Use the SHARED_WITH_ATTRIBUTES macro to create a universally usable function
* prototype for a function using GCC attributes.
* This macro works identically to SHARED(), but it adds a GCC attribute to the
* function. So far we use this to have printk parameters tested with a
* "format" attribute.
*
* @func function name
* @ret return value
* @attr function attributes
* @args function arguments
*/
#define SHARED_WITH_ATTRIBUTES(func,ret,attr,args...) \
FUNC(func,ret,attr,##args); \
EXTERN(func,ret,attr,##args)
#define EXPORT_SYMBOL(sym) extern typeof(sym) sym __attribute__((externally_visible,used))
#endif /* SHARED_H */