erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

The ABI wrapper from r775 made the SHARED definitions obsolete. They're

Browse source 
not that readable anyway, so kill them and use standard definitions
instead.

Introduce EXPORT_SYMBOL for shared symbols. EXPORT_SYMBOL tells the
compiler to use the standard calling conventions for a given symbol and
not to optimize it away.
Benefits:
- We can later use gcc -combine -fwhole-program without problems.
- It's a correctness fix for some optimizations.
- We could check for duplicated exported functions at link time.
- We could check whether exported functions are linked into initram or
stage2 by accident.
- We could generate usage statistics and possibly optimize away unused
shared functions.
- Through the above points, significant side reductions of 10-40%

Build and boot tested on qemu.
Build tested on all targets.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>


git-svn-id: svn://coreboot.org/repository/coreboot-v3@780 f3766cd6-281f-0410-b1cd-43a5c92072e9
This commit is contained in:
Carl-Daniel Hailfinger 2008-08-17 21:51:13 +00:00
commit 9342d1be4e
9 changed files with 65 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

24
include/device/pci_ops.h
View file

@ -30,13 +30,21 @@ void pci_write_config8(struct device * dev, unsigned where, u8 val);
void pci_write_config16(struct device * dev, unsigned where, u16 val);
void pci_write_config32(struct device * dev, unsigned where, u32 val);
SHARED(pci_conf1_read_config8, u8, u32 bdf, int where);
SHARED(pci_conf1_read_config16, u16, u32 bdf, int where);
SHARED(pci_conf1_read_config32, u32, u32 bdf, int where);
SHARED(pci_conf1_write_config8, void , u32 bdf, int where, u8 value);
SHARED(pci_conf1_write_config16, void, u32 bdf, int where, u16 value);
SHARED(pci_conf1_write_config32, void, u32 bdf, int where, u32 value);
SHARED(pci_conf1_find_on_bus, int, u16 bus, u16 vid, u16 did, u32 *busdevfn);
SHARED(pci_conf1_find_device, int, u16 vid, u16 did, u32 * dev);
u8 pci_conf1_read_config8(u32 bdf, int where);
EXPORT_SYMBOL(pci_conf1_read_config8);
u16 pci_conf1_read_config16(u32 bdf, int where);
EXPORT_SYMBOL(pci_conf1_read_config16);
u32 pci_conf1_read_config32(u32 bdf, int where);
EXPORT_SYMBOL(pci_conf1_read_config32);
void pci_conf1_write_config8(u32 bdf, int where, u8 value);
EXPORT_SYMBOL(pci_conf1_write_config8);
void pci_conf1_write_config16(u32 bdf, int where, u16 value);
EXPORT_SYMBOL(pci_conf1_write_config16);
void pci_conf1_write_config32(u32 bdf, int where, u32 value);
EXPORT_SYMBOL(pci_conf1_write_config32);
int pci_conf1_find_on_bus(u16 bus, u16 vid, u16 did, u32 *busdevfn);
EXPORT_SYMBOL(pci_conf1_find_on_bus);
int pci_conf1_find_device(u16 vid, u16 did, u32 * dev);
EXPORT_SYMBOL(pci_conf1_find_device);
#endif /* DEVICE_PCI_OPS_H */