erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/siemens/mc_ehl5: Use clrsetbits macro for register access

Browse source 
The code is simplified by using the mmio.h macros clrsetbits.

Change-Id: Iab71ab4d6e8b6c38e07641dae3b38093690543e8
Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85325
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Mario Scheithauer 2024-11-26 13:28:13 +01:00 • committed by Werner Zeh
commit 932b507907
1 changed files with 4 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/mainboard/siemens/mc_ehl/variants/mc_ehl5/mainboard.c
View file

@ -20,12 +20,10 @@
/* Disable SDR104 and SDR50 mode while keeping DDR50 mode enabled. */
static void disable_sdr_modes(struct resource *res)
{
uint32_t reg;
write32(res2mmio(res, MMC_CAP_BYP, 0), MMC_CAP_BYP_EN);
reg = read32(res2mmio(res, MMC_CAP_BYP_REG1, 0));
reg &= ~(MMC_CAP_BYP_SDR104 | MMC_CAP_BYP_SDR50);
reg |= MMC_CAP_BYP_DDR50;
write32(res2mmio(res, MMC_CAP_BYP_REG1, 0), reg);
clrsetbits32(res2mmio(res, MMC_CAP_BYP_REG1, 0),
MMC_CAP_BYP_SDR104 | MMC_CAP_BYP_SDR50,
MMC_CAP_BYP_DDR50);
}
void variant_mainboard_final(void)
@ -43,7 +41,6 @@ void variant_mainboard_final(void)
dev = pcidev_path_on_root(PCH_DEVFN_SDCARD);
if (dev) {
uint16_t reg16;
struct resource *res = probe_resource(dev, PCI_BASE_ADDRESS_0);
if (!res)
return;
@ -51,9 +48,7 @@ void variant_mainboard_final(void)
disable_sdr_modes(res);
/* Use preset driver strength from preset value registers. */
reg16 = read16(res2mmio(res, HOSTCTRL2, 0));
reg16 |= HOSTCTRL2_PRESET;
write16(res2mmio(res, HOSTCTRL2, 0), reg16);
clrsetbits16(res2mmio(res, HOSTCTRL2, 0), 0, HOSTCTRL2_PRESET);
}
dev = pcidev_path_on_root(PCH_DEVFN_EMMC);