From 91e2e3b5c030c95f3d7f8afbefbf33b487513ac9 Mon Sep 17 00:00:00 2001 From: Keith Hui Date: Mon, 17 Mar 2025 23:25:45 -0400 Subject: [PATCH] mb/hp/compaq_8300_elite_sff: Replace broken USB port config This board has an effectively broken USB configuration, which made itself known during testing on a Pro 6300 SFF, that could run an unmodified build for this variant and actually share the same vendor BIOS update file (sp95971 v3.08 rev A). Further examination of the BIOS update reveals five possible sets of USB port configurations for all models covered by that update, selected by PCH GPIOs 38 & 49, none of which matches what was currently coded. Then I received the autoport log from hardware with vendor BIOS that confirmed my theory. Therefore apply the USB port config found therein. While I'm at it, remove xhci_overcurrent_mapping, made obsolete by commit a3d1e6c4806e (sb/intel/bd82x6x: Apply EHCI mapping to xhci_overcurrent_mapping). Change-Id: Idc469b1aedcad2978247b9f6efbc7f55964e9ed1 Signed-off-by: Keith Hui Reviewed-on: https://review.coreboot.org/c/coreboot/+/86909 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- .../compaq_8300_elite_sff/overridetree.cb | 29 +++++++++---------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8300_elite_sff/overridetree.cb b/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8300_elite_sff/overridetree.cb index eb296f3dac..9a4e9eb3af 100644 --- a/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8300_elite_sff/overridetree.cb +++ b/src/mainboard/hp/snb_ivb_desktops/variants/compaq_8300_elite_sff/overridetree.cb @@ -8,22 +8,21 @@ chip northbridge/intel/sandybridge register "sata_port_map" = "0xf" register "superspeed_capable_ports" = "0x0000000f" register "xhci_switchable_ports" = "0x0000000f" - register "xhci_overcurrent_mapping" = "0x0000000f" register "usb_port_config" = "{ - { 1, 0, 0 }, - { 1, 0, 0 }, - { 1, 0, 1 }, - { 1, 0, 1 }, - { 1, 0, 2 }, - { 1, 0, 2 }, - { 1, 0, 3 }, - { 1, 0, 3 }, - { 1, 1, 4 }, - { 1, 0, 4 }, - { 1, 0, 6 }, - { 1, 0, 5 }, - { 1, 0, 5 }, - { 1, 0, 6 }, + {1, 0x84b, 0}, + {1, 0x84b, 0}, + {1, 0xa4b, 1}, + {1, 0xa4b, 1}, + {1, 0xb43, 2}, + {1, 0x94b, 2}, + {1, 0x94f, 3}, + {1, 0xb53, 3}, + {1, 1, 4}, + {1, 5, 4}, + {1, 0x65b, 6}, + {1, 0x65f, 5}, + {1, 0x84b, 5}, + {1, 0x94b, 6}, }" device ref xhci on end