erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UPSTREAM: soc/intel/apollolake: Do not use StackBase FSP-M parameter

Browse source 
Currently, StackBase field doesn't work and changing it from default
value leads to crash.

Change-Id: Id3f3ea9a834d0c04a8381938535109d6a729cca2
Original-Signed-off-by: Andrey Petrov <andrey.petrov@intel.com>
Original-Reviewed-on: https://review.coreboot.org/14803
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
(cherry-picked from commit 5ede3d8cce)
Signed-off-by: Martin Roth <martinroth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/346622
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Andrey Petrov 2016-04-15 21:32:30 -07:00 • committed by chrome-bot
commit 9179e8804d
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/soc/intel/apollolake/romstage.c
View file

@ -238,9 +238,13 @@ void platform_fsp_memory_init_params_cb(struct FSPM_UPD *mupd)
* requests.
* TODO: add checks to avoid overlap/conflict of CAR usage.
*/
/* fsp does not work with StackBase modified, so use default */
#if 0
/* FIXME: remove this once FSP is fixed */
mupd->FspmArchUpd.StackBase = _car_region_end -
mupd->FspmArchUpd.StackSize;
#endif
arch_upd->Bootmode = FSP_BOOT_WITH_FULL_CONFIGURATION;
if (IS_ENABLED(CONFIG_CACHE_MRC_SETTINGS)) {