From 90d87c59414bb2eeb3e880da35c1e719db2aee83 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Tue, 14 Oct 2025 20:42:23 +0100 Subject: [PATCH] mb/starlabs/starbook/*: Remove comments for unused GPIOs Non-functional change that makes it easier to see what is actually configured. Change-Id: I2ffb11ef73a0b2c9e5236b2edb9ec187a045374c Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/89582 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- .../starlabs/starbook/variants/adl/gpio.c | 156 ------------------ .../starlabs/starbook/variants/cml/gpio.c | 102 ------------ .../starlabs/starbook/variants/kbl/gpio.c | 123 +------------- .../starlabs/starbook/variants/rpl/gpio.c | 153 +---------------- .../starlabs/starbook/variants/tgl/gpio.c | 1 - 5 files changed, 8 insertions(+), 527 deletions(-) diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index bdc0e14212..012dc923cf 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -92,91 +92,49 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPD7, 0, PWROK), /* RTC Clock Delay [ Disabled / 95ms ] */ - /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), - /* GPD6: Sleep A */ PAD_NC(GPD6, NONE), - - /* GPD9: Wireless LAN Sleep */ PAD_NC(GPD9, NONE), - /* GPD10: Sleep S5 */ PAD_NC(GPD10, NONE), - /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE), - /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), - /* A6: Not Connected */ PAD_NC(GPP_A6, NONE), - /* A7: Embedded Controller SCI */ PAD_NC(GPP_A7, NONE), - /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A11: Not Connected */ PAD_NC(GPP_A11, NONE), /* A12: PCH M.2 SSD PEDET */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), - /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), - /* A15: Test Point 52 */ PAD_NC(GPP_A15, NONE), - /* A16: USB OverCurrent 3 */ PAD_NC(GPP_A16, NONE), - /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), - /* A20: Test Point 44 */ PAD_NC(GPP_A20, NONE), - /* A21: Fingerprint Reader Interrupt */ PAD_NC(GPP_A21, NONE), - /* A22: Fingerprint Reader Reset */ PAD_NC(GPP_A22, NONE), - /* A23: Not Connected */ PAD_NC(GPP_A23, NONE), - /* B3: Not Connected */ PAD_NC(GPP_B3, NONE), - /* B4: Not Connected */ PAD_NC(GPP_B4, NONE), - /* B5: I2C 2 SDA Touch Panel SDA */ PAD_NC(GPP_B5, NONE), - /* B6: I2C 2 SCL Touch Panel Clock */ PAD_NC(GPP_B6, NONE), - /* B7: I2C 3 SDA Test Point 15 */ PAD_NC(GPP_B7, NONE), - /* B8: I2C 3 SCL Test Point 16 */ PAD_NC(GPP_B8, NONE), - /* B9: Not Connected */ PAD_NC(GPP_B9, NONE), - /* B10: Not Connected */ PAD_NC(GPP_B10, NONE), - /* B11: I2C PMC PD Interrupt Test Point 28 */ PAD_NC(GPP_B11, NONE), - /* B12: PM SLP S0 */ PAD_NC(GPP_B12, NONE), - - /* B15: Not Connected */ PAD_NC(GPP_B15, NONE), - /* B16: Not Connected */ PAD_NC(GPP_B16, NONE), - /* B17: Not Connected */ PAD_NC(GPP_B17, NONE), - - /* B19: Not Connected */ PAD_NC(GPP_B19, NONE), - /* B20: Not Connected */ PAD_NC(GPP_B20, NONE), - /* B21: Not Connected */ PAD_NC(GPP_B21, NONE), - /* B22: Not Connected */ PAD_NC(GPP_B22, NONE), - /* B23: Not used MiPi Camera */ PAD_NC(GPP_B23, NONE), - /* B24: Not Connected */ PAD_NC(GPP_B24, NONE), - /* B25: Not Connected */ PAD_NC(GPP_B25, NONE), - /* C3: SML 0 Clock */ PAD_CFG_NF(GPP_C3, NONE, DEEP, NF1), /* C4: SML 0 Data */ @@ -186,243 +144,129 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_C6, NONE, DEEP, NF1), /* C7: SML 1 Data */ PAD_CFG_NF(GPP_C7, NONE, DEEP, NF1), - /* C8: Not Connected */ PAD_NC(GPP_C8, NONE), - /* C9: Not Connected */ PAD_NC(GPP_C9, NONE), - /* C10: Not Connected */ PAD_NC(GPP_C10, NONE), - /* C11: Not Connected */ PAD_NC(GPP_C11, NONE), - /* C12: Not Connected */ PAD_NC(GPP_C12, NONE), - /* C13: Not Connected */ PAD_NC(GPP_C13, NONE), - /* C14: Not Connected */ PAD_NC(GPP_C14, NONE), - /* C15: Not Connected */ PAD_NC(GPP_C15, NONE), - /* C16: Not Connected */ PAD_NC(GPP_C16, NONE), - /* C17: Not Connected */ PAD_NC(GPP_C17, NONE), - /* C18: Not Connected */ PAD_NC(GPP_C18, NONE), - /* C19: Not Connected */ PAD_NC(GPP_C19, NONE), - /* C20: Not Connected */ PAD_NC(GPP_C20, NONE), - /* C21: Not Connected */ PAD_NC(GPP_C21, NONE), - /* C22: Not Connected */ PAD_NC(GPP_C22, NONE), - /* C23: Not Connected */ PAD_NC(GPP_C23, NONE), - /* D0: Not used Audio ID 0 */ PAD_NC(GPP_D0, NONE), - /* D1: Not used Audio ID 1 */ PAD_NC(GPP_D1, NONE), - /* D2: Not used Audio ID 2 */ PAD_NC(GPP_D2, NONE), - /* D3: Not Connected */ PAD_NC(GPP_D3, NONE), - /* D4: Not Connected */ PAD_NC(GPP_D4, NONE), - /* D5: Clock Request 0 */ PAD_NC(GPP_D5, NONE), - /* D8: Clock Request 3 LAN */ PAD_NC(GPP_D8, NONE), - /* D9: GSPI 2 FPS */ PAD_NC(GPP_D9, NONE), - /* D10: GSPI 2 Clock */ PAD_NC(GPP_D10, NONE), - /* D11: GSPI 2 MISO FPS */ PAD_NC(GPP_D11, NONE), - /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), - /* D13: Wireless LAN Wake */ PAD_NC(GPP_D13, NONE), - /* D14: CPU M.2 SSD Power Enable */ PAD_NC(GPP_D14, NONE), - /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), - /* D17: Not used Fingerprint ID */ PAD_NC(GPP_D17, NONE), - /* D18: Not Connected */ PAD_NC(GPP_D18, NONE), - /* D19: Test Point 21 */ PAD_NC(GPP_D19, NONE), - /* E0: SATA x PCIe */ PAD_NC(GPP_E0, NONE), - /* E1: Not used Accelerometer Interrupt */ PAD_NC(GPP_E1, NONE), - /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), - /* E4: Test Point 14 */ PAD_NC(GPP_E4, NONE), - /* E5: Not Connected */ PAD_NC(GPP_E5, NONE), - - /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), - /* E9: USB OverCurrent 0 */ PAD_NC(GPP_E9, NONE), - /* E10: PWD Amplifier Input */ PAD_NC(GPP_E10, NONE), - /* E13: Not connected */ PAD_NC(GPP_E13, NONE), - /* E15: Not Connected */ PAD_NC(GPP_E15, NONE), - /* E16: Not Connected */ PAD_NC(GPP_E16, NONE), - /* E17: Not Connected */ PAD_NC(GPP_E17, NONE), - /* E18: Not Connected */ PAD_NC(GPP_E18, NONE), - - /* E20: Not Connected */ PAD_NC(GPP_E20, NONE), - /* E21: Not Connected */ PAD_NC(GPP_E21, NONE), - /* E22: Not Connected */ PAD_NC(GPP_E22, NONE), - /* E23: Not Connected */ PAD_NC(GPP_E23, NONE), - /* F0: CNV BRI Data */ PAD_NC(GPP_F0, NONE), - /* F1: CNV BRI Response */ PAD_NC(GPP_F1, NONE), - - /* F3: CNV RGI Response */ PAD_NC(GPP_F3, NONE), - /* F4: CNV RF Reset */ PAD_NC(GPP_F4, NONE), - /* F5: Not used MODEM_CLKREQ */ PAD_NC(GPP_F5, NONE), - /* F6: CNV PA Blanking */ PAD_NC(GPP_F6, NONE), - /* F8: Not Connected */ PAD_NC(GPP_F8, NONE), - /* F9: EC Sleep S0 */ PAD_NC(GPP_F9, NONE), /* F10: Weak Internal PD 20K */ PAD_CFG_GPO(GPP_F10, 0, DEEP), - /* F11: TPM ID */ PAD_NC(GPP_F11, NONE), - /* F12: Not Connected */ PAD_NC(GPP_F12, NONE), - /* F13: Not Connected */ PAD_NC(GPP_F13, NONE), - /* F14: Not Connected */ PAD_NC(GPP_F14, NONE), - /* F15: Not used Accelerometer Interrupt 2*/ PAD_NC(GPP_F15, NONE), - /* F16: Not Connected */ PAD_NC(GPP_F16, NONE), - /* F17: Not used Touch Panel Reset */ PAD_NC(GPP_F17, NONE), - /* F18: Not used Touch Panel Interrupt */ PAD_NC(GPP_F18, NONE), - /* F19: Not Connected */ PAD_NC(GPP_F19, NONE), - /* F20: CPU M.2 SSD Reset */ PAD_NC(GPP_F20, NONE), - /* F21: GPPC_F21 */ PAD_NC(GPP_F21, NONE), - /* F22: Not Connected */ PAD_NC(GPP_F22, NONE), - /* F23: Not Connected */ PAD_NC(GPP_F23, NONE), - /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), - /* H6: Not Connected */ PAD_NC(GPP_H6, NONE), - /* H7: Not Connected */ PAD_NC(GPP_H7, NONE), - /* H8: I2C 4 SDA GSensor */ PAD_NC(GPP_H8, NONE), - /* H9: I2C 4 SDL GSensor */ PAD_NC(GPP_H9, NONE), - /* H12: Not Connected */ PAD_NC(GPP_H12, NONE), /* H13: PCH M.2 SSD Device Sleep */ PAD_CFG_NF(GPP_H13, NONE, DEEP, NF5), - /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), - /* H16: Not Connected */ PAD_NC(GPP_H16, NONE), - /* H19: Clock Request 4 CPU M.2 SSD */ PAD_NC(GPP_H19, NONE), - /* H20: Not Connected */ PAD_NC(GPP_H20, NONE), - /* H21: Not Connected */ PAD_NC(GPP_H21, NONE), - /* H22: Not Connected */ PAD_NC(GPP_H22, NONE), - /* H23: Clock Request 5 */ PAD_NC(GPP_H23, NONE), - /* S0: Not Connected */ PAD_NC(GPP_S0, NONE), - /* S1: Not Connected */ PAD_NC(GPP_S1, NONE), - /* S2: DMIC Clock */ PAD_NC(GPP_S2, NONE), - /* S3: DMIC Data */ PAD_NC(GPP_S3, NONE), - /* S4: Not Connected */ PAD_NC(GPP_S4, NONE), - /* S5: Not Connected */ PAD_NC(GPP_S5, NONE), - /* S6: Not Connected */ PAD_NC(GPP_S6, NONE), - /* S7: Not Connected */ PAD_NC(GPP_S7, NONE), - /* T0: Not Connected */ PAD_NC(GPP_T0, NONE), - /* T1: Not Connected */ PAD_NC(GPP_T1, NONE), - /* T2: Not Connected */ PAD_NC(GPP_T2, NONE), - /* T3: Not Connected */ PAD_NC(GPP_T3, NONE), - /* T4: Not Connected */ PAD_NC(GPP_T4, NONE), - /* T5: Not Connected */ PAD_NC(GPP_T5, NONE), - /* T6: Not Connected */ PAD_NC(GPP_T6, NONE), - /* T7: Not Connected */ PAD_NC(GPP_T7, NONE), - /* T8: Not Connected */ PAD_NC(GPP_T8, NONE), - /* T9: Not Connected */ PAD_NC(GPP_T9, NONE), - /* T10: Not Connected */ PAD_NC(GPP_T10, NONE), - /* T11: Not Connected */ PAD_NC(GPP_T11, NONE), - /* T12: Not Connected */ PAD_NC(GPP_T12, NONE), - /* T13: Not Connected */ PAD_NC(GPP_T13, NONE), - /* T14: Not Connected */ PAD_NC(GPP_T14, NONE), - /* T15: Not Connected */ PAD_NC(GPP_T15, NONE), - /* R5: MiPi Cam Reset */ PAD_NC(GPP_R5, NONE), - /* R6: Not Connected */ PAD_NC(GPP_R6, NONE), - /* R7: Not Connected */ PAD_NC(GPP_R7, NONE), }; diff --git a/src/mainboard/starlabs/starbook/variants/cml/gpio.c b/src/mainboard/starlabs/starbook/variants/cml/gpio.c index a844562817..601b273036 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/cml/gpio.c @@ -67,7 +67,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* Clock */ PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ - /* GPD2: LAN_WAKE# */ PAD_NC(GPD2, NONE), /* GPD6: SIO_SLP_A# */ PAD_CFG_NF(GPD6, NONE, DEEP, NF1), @@ -94,17 +93,13 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_A5, NONE, DEEP, NF1), /* A6: LPC_SERIRQ */ PAD_CFG_NF(GPP_A6, NONE, DEEP, NF1), - /* A7: Not Connected */ PAD_NC(GPP_A7, NONE), /* A8: GPPC_A8_CLKRUN_N */ PAD_CFG_NF(GPP_A8, NONE, DEEP, NF1), /* A9: ESPI_CLK */ PAD_CFG_NF(GPP_A9, DN_20K, DEEP, NF1), - /* A10: Not Connected */ PAD_NC(GPP_A10, NONE), - /* A11: Not Connected */ PAD_NC(GPP_A11, NONE), - /* A12: TABLET_MODE_CTRL */ PAD_NC(GPP_A12, NONE), /* A13: SUSPWRDNACK */ PAD_CFG_GPO(GPP_A13, 1, PLTRST), @@ -112,38 +107,24 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_A14, NONE, DEEP, NF1), /* A15: SPK_PD_N */ PAD_CFG_GPO(GPP_A15, 1, PLTRST), - /* A16: Not Connected */ PAD_NC(GPP_A16, NONE), - /* A17: SAR_DPR_PCH */ PAD_NC(GPP_A17, NONE), - /* A18: ACCEL1_INT1 */ PAD_NC(GPP_A18, UP_20K), - /* A19: ACCEL2_INT1 */ PAD_NC(GPP_A19, UP_20K), - /* A20: HUMAN_PRESENCE_INT_N */ PAD_NC(GPP_A20, UP_20K), - /* A21: HALL_SENSOR_INT */ PAD_NC(GPP_A21, UP_20K), - /* A22: SAR_NIRQ_PCH */ PAD_NC(GPP_A22, UP_20K), - /* A23: INT_SHARED */ PAD_NC(GPP_A23, UP_20K), - /* B0: Not Connected */ PAD_NC(GPP_B0, NONE), - /* B1: Not Connected */ PAD_NC(GPP_B1, NONE), - /* B2: Not Connected */ PAD_NC(GPP_B2, NONE), /* B5: WLAN_CLKREQ# */ PAD_CFG_NF(GPP_B5, NONE, DEEP, NF1), /* B7: LAN_CLKREQ# */ PAD_CFG_NF(GPP_B7, NONE, DEEP, NF1), - /* B8: Not Connected */ PAD_NC(GPP_B8, NONE), - /* B9: Not Connected */ PAD_NC(GPP_B9, NONE), - /* B10: Not Connected */ PAD_NC(GPP_B10, NONE), /* B11: EXT_PWR_GATE_N */ PAD_CFG_GPO(GPP_B11, 1, PLTRST), @@ -151,7 +132,6 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), /* B14: TCH_PNL_PWR_EN */ PAD_CFG_GPO(GPP_B14, 1, PLTRST), - /* B15: Not Connected */ PAD_NC(GPP_B15, NONE), /* B16: FPS_INT */ PAD_CFG_GPI_APIC(GPP_B16, NONE, PLTRST, LEVEL, NONE), @@ -159,75 +139,46 @@ const struct pad_config gpio_table[] = { PAD_CFG_GPO(GPP_B17, 1, PLTRST), /* B18: AR_CIO_PWR_EN */ PAD_CFG_GPO(GPP_B18, 0, DEEP), - /* B19: GSPI1_CS0_FPS_N */ PAD_NC(GPP_B19, NONE), - /* B20: GSPI1_CLK_FPS */ PAD_NC(GPP_B20, NONE), - /* B21: GSPI1_MISO_FPS */ PAD_NC(GPP_B21, NONE), /* B22: GSPI1_MOSI_FPS */ PAD_CFG_GPO(GPP_B22, 0, DEEP), - /* B23: EC_SLP_S0IX_N */ PAD_NC(GPP_B23, NONE), - /* C3: Not Connected */ PAD_NC(GPP_C3, NONE), - /* C4: Not Connected */ PAD_NC(GPP_C4, NONE), /* C5: SML0ALERT */ PAD_CFG_GPO(GPP_C5, 0, DEEP), - /* C6: Not Connected */ PAD_NC(GPP_C6, NONE), - /* C7: Not Connected */ PAD_NC(GPP_C7, NONE), /* C8: CODEC_INT_N */ PAD_CFG_GPI_APIC_LOW(GPP_C8, UP_20K, PLTRST), - /* C9: Not Connected */ PAD_NC(GPP_C9, NONE), - /* C10: Not Connected */ PAD_NC(GPP_C10, NONE), - /* C11: Not Connected */ PAD_NC(GPP_C11, NONE), /* C12: PCIE_NAND_RST_R_N */ PAD_CFG_GPO(GPP_C12, 1, PLTRST), - /* C13: M2_SSD_PWREN */ PAD_NC(GPP_C13, NONE), - /* C14: TBT_WAKE_MUX_SEL_N */ PAD_NC(GPP_C14, NONE), - /* C15: TBT_RST_N */ PAD_NC(GPP_C15, NONE), - /* C18: TOUCH_I2C_SDA */ PAD_NC(GPP_C18, NONE), - /* C19: TOUCH_I2C_SDL */ PAD_NC(GPP_C19, NONE), - /* C22: AR1_USB_PWR_EN */ PAD_NC(GPP_C22, NONE), - /* C23: Not Connected */ PAD_NC(GPP_C23, NONE), - /* D0: TPM_IRQ */ PAD_NC(GPP_D0, NONE), - /* D1: Not Connected */ PAD_NC(GPP_D1, NONE), - /* D2: Not Connected */ PAD_NC(GPP_D2, NONE), - /* D3: Not Connected */ PAD_NC(GPP_D3, NONE), - /* D4: Not Connected */ PAD_NC(GPP_D4, NONE), - /* D5: Not Connected */ PAD_NC(GPP_D5, NONE), - /* D6: Not Connected */ PAD_NC(GPP_D6, NONE), - /* D7: ISH_I2C1_SDA */ PAD_NC(GPP_D7, NONE), - /* D8: ISH_I2C1_SDL */ PAD_NC(GPP_D8, NONE), /* D9: TCH_PNL2_RST_R_N */ PAD_CFG_GPO(GPP_D9, 1, PLTRST), - /* D10: TCH_PNL2_INT_R_N */ PAD_NC(GPP_D10, NATIVE), - /* D11: Not Connected */ PAD_NC(GPP_D11, NATIVE), /* D12: GPPC_D_12 */ PAD_CFG_GPO(GPP_D12, 0, DEEP), @@ -235,7 +186,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_D13, NONE), /* D14: TCH_PNL1_RST_N */ PAD_CFG_GPO(GPP_D14, 1, PLTRST), - /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), /* D16: GPIO_2_EC */ PAD_CFG_GPO(GPP_D16, 0, PWROK), @@ -247,30 +197,19 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_D19, NONE, DEEP, NF1), /* D20: DMIC_DATA_0 */ PAD_CFG_NF(GPP_D20, NONE, DEEP, NF1), - /* D21: Not Connected */ PAD_NC(GPP_D21, NONE), - /* D22: TPM_RST */ PAD_NC(GPP_D22, NONE), - /* D23: TPM_IRQ */ PAD_NC(GPP_D23, NONE), - /* E0: Not Connected */ PAD_NC(GPP_E0, NONE), /* E1: GPPC_E1_SATAXPCIE_1_SATAGP_1 */ PAD_CFG_NF(GPP_E1, UP_20K, DEEP, NF1), - /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), - /* E3: Not Connected */ PAD_NC(GPP_E3, NONE), - /* E4: Not Connected */ PAD_NC(GPP_E4, NONE), - /* E5: GPPC_E5_SATA_DEVSLP_1 */ PAD_NC(GPP_E5, NONE), - /* E6: Not Connected */ PAD_NC(GPP_E6, NONE), - /* E7: Not Connected */ PAD_CFG_GPI(GPP_E7, NONE, PLTRST), - /* E8: Not Connected */ PAD_NC(GPP_E8, NONE), /* E9: GPPC_E9_USB2_OCB_0 */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), @@ -289,99 +228,58 @@ const struct pad_config gpio_table[] = { /* E21: DDI2_CTRL_DATA */ PAD_CFG_NF(GPP_E21, NONE, DEEP, NF1), - /* F0: Not Connected */ PAD_NC(GPP_F0, NONE), - /* F1: Not Connected */ PAD_NC(GPP_F1, NONE), - /* F2: Not Connected */ PAD_NC(GPP_F2, NONE), - /* F3: Not Connected */ PAD_NC(GPP_F3, NONE), - /* F8: Not Connected */ PAD_NC(GPP_F8, NONE), - /* F9: Not Connected */ PAD_NC(GPP_F9, NONE), - /* F10: Not Connected */ PAD_NC(GPP_F10, NONE), - /* F11: EMMC_CMD */ PAD_NC(GPP_F11, NONE), - /* F12: EMMC_DATA_0 */ PAD_NC(GPP_F12, NONE), - /* F13: EMMC_DATA_1 */ PAD_NC(GPP_F13, NONE), - /* F14: EMMC_DATA_2 */ PAD_NC(GPP_F14, NONE), - /* F15: EMMC_DATA_3 */ PAD_NC(GPP_F15, NONE), - /* F16: EMMC_DATA_4 */ PAD_NC(GPP_F16, NONE), - /* F17: EMMC_DATA_5 */ PAD_NC(GPP_F17, NONE), - /* F18: EMMC_DATA_6 */ PAD_NC(GPP_F18, NONE), - /* F19: EMMC_DATA_7 */ PAD_NC(GPP_F19, NONE), - /* F20: EMMC_STROBE */ PAD_NC(GPP_F20, NONE), - /* F21: EMMC_CLK */ PAD_NC(GPP_F21, NONE), - /* F22: EMMC_RESETB */ PAD_NC(GPP_F22, NONE), /* F23: A4WP_PRESENT */ PAD_CFG_NF(GPP_F23, DN_20K, DEEP, NF1), - /* G0: Not Connected */ PAD_NC(GPP_G0, NONE), - /* G1: Not Connected */ PAD_NC(GPP_G1, NONE), - /* G2: Not Connected */ PAD_NC(GPP_G2, NONE), - /* G3: Not Connected */ PAD_NC(GPP_G3, NONE), - /* G4: Not Connected */ PAD_NC(GPP_G4, NONE), - /* G5: Not Connected */ PAD_NC(GPP_G5, UP_20K), - /* G6: Not Connected */ PAD_NC(GPP_G6, NONE), - /* G7: Not Connected */ PAD_NC(GPP_G7, DN_20K), - /* H0: Not Connected */ PAD_NC(GPP_H0, NONE), - /* H3: Not Connected */ PAD_NC(GPP_H3, UP_20K), - /* H4: GSENSOR_I2C_SDA */ PAD_NC(GPP_H4, NONE), - /* H5: GSENSOR_I2C_SCL */ PAD_NC(GPP_H5, NONE), - /* H8: Not Connected */ PAD_NC(GPP_H8, NONE), - /* H9: Not Connected */ PAD_NC(GPP_H9, NONE), /* H10: ISH_I2C2_SDA */ PAD_CFG_GPO(GPP_H10, 1, PLTRST), /* H11: ISH_I2C2_SCL */ PAD_CFG_GPO(GPP_H11, 1, PLTRST), - /* H12: Not Connected */ PAD_NC(GPP_H12, NONE), - /* H13: Not Connected */ PAD_NC(GPP_H13, NONE), - /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), - /* H15: Not Connected */ PAD_NC(GPP_H15, NONE), - /* H16: Not Connected */ PAD_NC(GPP_H16, NONE), /* H17: GPPC_H_17_WWAN_DISABLE_N */ PAD_CFG_GPO(GPP_H17, 0, DEEP), - /* H19: Not Connected */ PAD_NC(GPP_H19, NONE), - /* H20: Not Connected */ PAD_NC(GPP_H20, NONE), /* H21: GPPC_H21 */ PAD_CFG_GPO(GPP_H21, 0, DEEP), - /* H22: Not Connected */ PAD_NC(GPP_H22, NONE), /* H23: GPPC_H23 */ PAD_CFG_GPO(GPP_H23, 0, DEEP), diff --git a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c index cdc34ae46f..03d8ffcc9b 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/gpio.c @@ -51,19 +51,13 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_C0, NONE, DEEP, NF1), /* Clock */ PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ - /* GPD2: Not Connected */ PAD_NC(GPD2, NONE), - /* GPD6: Not Connected */ PAD_NC(GPD6, NONE), - /* GPD7: Not Connected */ PAD_NC(GPD7, NONE), - /* GPD9: Not Connected */ PAD_NC(GPD9, NONE), - /* GPD10: Not Connected */ PAD_NC(GPD10, NONE), - /* GPD11: Not Connected */ PAD_NC(GPD11, NONE), - /* GPP_A0: KBRST_N */ + PAD_NC(GPP_A0, NONE), /* GPP_A1: LDC_AD0 */ PAD_CFG_NF(GPP_A1, NONE, DEEP, NF1), @@ -77,47 +71,30 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_A5, NONE, DEEP, NF1), /* GPP_A6: LPC_SERIRQ */ PAD_CFG_NF(GPP_A6, NONE, DEEP, NF1), - /* GPP_A7: Not Connected */ PAD_NC(GPP_A7, NONE), /* GPP_A8: PM_CLKRUN_N */ PAD_CFG_NF(GPP_A8, NONE, DEEP, NF1), /* GPP_A9: LPC_CLK_EC */ PAD_CFG_NF(GPP_A9, DN_20K, DEEP, NF1), - /* GPP_A10: LPC_CLK_Debug */ PAD_NC(GPP_A10, DN_20K), /* GPP_A11: PME_N */ PAD_CFG_GPI(GPP_A11, DN_20K, DEEP), - /* GPP_A12: Not Connected */ PAD_NC(GPP_A12, NONE), - /* GPP_A13: SUSPWRDNACK */ PAD_NC(GPP_A13, DN_20K), - /* GPP_A14: PM_SUS_STAT_N */ PAD_NC(GPP_A14, DN_20K), - /* GPP_A15: SUSACK# */ PAD_NC(GPP_A15, DN_20K), - /* GPP_A16: Not Connected */ PAD_NC(GPP_A16, DN_20K), - /* GPP_A17: Not Connected */ PAD_NC(GPP_A17, DN_20K), - /* GPP_A18: Not Connected */ PAD_NC(GPP_A18, DN_20K), - /* GPP_A19: Not Connected */ PAD_NC(GPP_A19, DN_20K), - /* GPP_A20: Not Connected */ PAD_NC(GPP_A20, NONE), - /* GPP_A21: Not Connected */ PAD_NC(GPP_A21, DN_20K), - /* GPP_A22: FP_SSP0_INT */ PAD_NC(GPP_A22, DN_20K), - /* GPP_A23: FP_SSP0_RST */ PAD_NC(GPP_A23, DN_20K), - /* GPP_B0: Not Connected */ + PAD_NC(GPP_B0, DN_20K), - /* GPP_B1: Not Connected */ PAD_NC(GPP_B1, DN_20K), - /* GPP_B2: +V3P3A_PCH */ PAD_NC(GPP_B2, DN_20K), - /* GPP_B3: Not Connected */ PAD_NC(GPP_B3, DN_20K), /* GPP_B5: SRCCLKREQ0# */ PAD_CFG_NF(GPP_B5, NONE, DEEP, NF1), @@ -129,41 +106,24 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_B8, DN_20K, DEEP, NF1), /* GPP_B9: WLAN_CLKREQ# */ PAD_CFG_NF(GPP_B9, NONE, DEEP, NF1), - /* GPP_B11: Not Connected */ PAD_NC(GPP_B11, DN_20K), - /* GPP_B12 SLP_S0_N */ PAD_NC(GPP_B12, DN_20K), - /* GPP_B14: HDA_SPKR */ PAD_NC(GPP_B14, DN_20K), - /* GPP_B15: Not Connected */ PAD_NC(GPP_B15, DN_20K), - /* GPP_B16: Not Connected */ PAD_NC(GPP_B16, DN_20K), - /* GPP_B17: Not Connected */ PAD_NC(GPP_B17, DN_20K), - /* GPP_B18: +V3P3A_PCH */ PAD_NC(GPP_B18, DN_20K), - /* GPP_B19: FP_SSP0_CS */ PAD_NC(GPP_B19, DN_20K), - /* GPP_B20: FP_SSP0_CLK */ PAD_NC(GPP_B20, DN_20K), - /* GPP_21: FP_SSP0_MISO */ PAD_NC(GPP_B21, DN_20K), - /* GPP_22: FP_SSP0_MOSI */ PAD_NC(GPP_B22, DN_20K), - /* GPP_B23: SML1ALERT#/PCHHOT# */ PAD_NC(GPP_B23, DN_20K), - /* GPP_C2: SMBALERT# */ + PAD_NC(GPP_C2, DN_20K), - /* GPP_C3: SML0CLK */ PAD_NC(GPP_C3, DN_20K), - /* GPP_C4: SML0DATA */ PAD_NC(GPP_C4, DN_20K), - /* GPP_C5: SML0ALERT# */ PAD_NC(GPP_C5, DN_20K), - /* GPP_C6: SML1CLK */ PAD_NC(GPP_C6, DN_20K), - /* GPP_C7: SML1DATA */ PAD_NC(GPP_C7, DN_20K), /* GPP_C8: UART0_RXD */ PAD_CFG_NF(GPP_C8, UP_20K, DEEP, NF1), @@ -173,83 +133,49 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_C10, NONE, DEEP, NF1), /* GPP_C11: UART0_CTS# */ PAD_CFG_NF(GPP_C11, UP_20K, DEEP, NF1), - /* GPP_C12: Not Connected */ PAD_NC(GPP_C12, UP_20K), - /* GPP_C13: Not Connected */ PAD_NC(GPP_C13, UP_20K), - /* GPP_C14: Not Connected */ PAD_NC(GPP_C14, UP_20K), - /* GPP_C15: Not Connected */ PAD_NC(GPP_C15, UP_20K), /* GPP_C18: TOUCH_I2C_SDA */ PAD_CFG_NF(GPP_C18, NONE, DEEP, NF1), /* GPP_C19: TOUCH_I2C_CLK */ PAD_CFG_NF(GPP_C19, NONE, DEEP, NF1), - /* GPP_C22: Not Connected */ PAD_NC(GPP_C22, NONE), - /* GPP_D0: Not Connected */ + PAD_NC(GPP_D0, DN_20K), - /* GPP_D1: Not Connected */ PAD_NC(GPP_D1, DN_20K), - /* GPP_D2: Not Connected */ PAD_NC(GPP_D2, DN_20K), - /* GPP_D3: Not Connected */ PAD_NC(GPP_D3, DN_20K), - /* GPP_D4: Not Connected */ PAD_NC(GPP_D4, DN_20K), - /* GPP_D5: Not Connected */ PAD_NC(GPP_D5, DN_20K), - /* GPP_D6: Not Connected */ PAD_NC(GPP_D6, DN_20K), - /* GPP_D7: Not Connected */ PAD_NC(GPP_D7, DN_20K), - /* GPP_D8: Not Connected */ PAD_NC(GPP_D8, DN_20K), - /* GPP_D9: VOLUME_UP */ PAD_NC(GPP_D9, DN_20K), - /* GPP_D10: VOLUME_DOWN */ PAD_NC(GPP_D10, DN_20K), - /* GPP_D11: Not Connected */ PAD_NC(GPP_D11, DN_20K), - /* GPP_D12: Not Connected */ PAD_NC(GPP_D12, DN_20K), - /* GPP_D13: Not Connected */ PAD_NC(GPP_D13, DN_20K), - /* GPP_D14: GPP_D14 */ PAD_NC(GPP_D14, DN_20K), - /* GPP_D15: GPP_D15 */ PAD_NC(GPP_D15, DN_20K), - /* GPP_D16: GPP_D16 */ PAD_NC(GPP_D16, DN_20K), - /* GPP_D17: PCH_AUDIO_PWREN */ PAD_NC(GPP_D17, DN_20K), - /* GPP_D18: Not Connected */ PAD_NC(GPP_D18, DN_20K), - /* GPP_D19: Not Connected */ PAD_NC(GPP_D19, DN_20K), - /* GPP_D21: Not Connected */ PAD_NC(GPP_D21, DN_20K), - /* GPP_D22: Not Connected */ PAD_NC(GPP_D22, DN_20K), - /* GPP_D23: Not Connected */ PAD_NC(GPP_D23, DN_20K), - /* GPP_E0: Not Connected */ + PAD_NC(GPP_E0, DN_20K), - /* GPP_E1: Not Connected */ PAD_NC(GPP_E1, DN_20K), - /* GPP_E2: SATA2_SSD_Type */ PAD_NC(GPP_E2, DN_20K), - /* GPP_E3: Not Connected */ PAD_NC(GPP_E3, DN_20K), - /* GPP_E4: Not Connected */ PAD_NC(GPP_E4, DN_20K), - /* GPP_E5: Not Connected */ PAD_NC(GPP_E5, DN_20K), /* GPP_E6: SATA2_SSD_DEVSLP */ PAD_CFG_NF(GPP_E6, NONE, PWROK, NF1), - /* GPP_E7: TOUCH_PANEL_INT_N */ PAD_NC(GPP_E7, DN_20K), - /* GPP_E8: Not Connected */ PAD_NC(GPP_E8, DN_20K), /* GPP_E9: USB2_P1_WP1_OC_N */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), @@ -257,83 +183,48 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_E10, NONE, DEEP, NF1), /* GPP_E11: USB2_P3_WP2_OC_N */ PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1), - /* GPP_E12: Not Connected */ PAD_NC(GPP_E12, DN_20K), /* E15: SMC_SMI_N */ PAD_CFG_GPI_SMI_LOW(GPP_E15, NONE, DEEP, EDGE_SINGLE), /* E16: SMC_SCI_N */ PAD_CFG_GPI_SCI_LOW(GPP_E16, NONE, PLTRST, LEVEL), - /* GPP_E20: Not Connected */ PAD_NC(GPP_E20, DN_20K), - /* GPP_E21: DDI2_DDC_SDA */ PAD_NC(GPP_E21, DN_20K), - /* GPP_E22: Not Connected */ PAD_NC(GPP_E22, DN_20K), - /* GPP_E23: TOUCH_PANEL_RESET_N */ PAD_NC(GPP_E23, DN_20K), - /* GPP_F0: Not Connected */ + PAD_NC(GPP_F0, DN_20K), - /* GPP_F1: Not Connected */ PAD_NC(GPP_F1, DN_20K), - /* GPP_F2: Not Connected */ PAD_NC(GPP_F2, DN_20K), - /* GPP_F3: Not Connected */ PAD_NC(GPP_F3, DN_20K), - /* GPP_F4: GSENSOR_I2C_SDA */ PAD_NC(GPP_F4, DN_20K), - /* GPP_F5: GSENSOR_I2C_SCL */ PAD_NC(GPP_F5, DN_20K), - /* GPP_F6: Not Connected */ PAD_NC(GPP_F6, DN_20K), - /* GPP_F7: Not Connected */ PAD_NC(GPP_F7, DN_20K), - /* GPP_F8: Not Connected */ PAD_NC(GPP_F8, NONE), - /* GPP_F9: Not Connected */ PAD_NC(GPP_F9, NONE), - /* GPP_F10: ACCEL2_INT */ PAD_NC(GPP_F10, DN_20K), - /* GPP_F11: ACCEL1_INT */ PAD_NC(GPP_F11, DN_20K), - /* GPP_F12: Not Connected */ PAD_NC(GPP_F12, DN_20K), - /* GPP_F13: Not Connected */ PAD_NC(GPP_F13, DN_20K), - /* GPP_F14: Not Connected */ PAD_NC(GPP_F14, DN_20K), - /* GPP_F15: Not Connected */ PAD_NC(GPP_F15, DN_20K), - /* GPP_F16: Not Connected */ PAD_NC(GPP_F16, DN_20K), - /* GPP_F17: Not Connected */ PAD_NC(GPP_F17, DN_20K), - /* GPP_F18: Not Connected */ PAD_NC(GPP_F18, DN_20K), - /* GPP_F19: Not Connected */ PAD_NC(GPP_F19, DN_20K), - /* GPP_F20: Not Connected */ PAD_NC(GPP_F20, DN_20K), - /* GPP_F21: Not Connected */ PAD_NC(GPP_F21, DN_20K), - /* GPP_F22: Not Connected */ PAD_NC(GPP_F22, DN_20K), - /* GPP_F23: Not Connected */ PAD_NC(GPP_F23, DN_20K), - /* GPP_G0: Not Connected */ + PAD_NC(GPP_G0, NONE), - /* GPP_G1: Not Connected */ PAD_NC(GPP_G1, NONE), - /* GPP_G2: Not Connected */ PAD_NC(GPP_G2, NONE), - /* GPP_G3: Not Connected */ PAD_NC(GPP_G3, NONE), - /* GPP_G4: Not Connected */ PAD_NC(GPP_G4, NONE), - /* GPP_G5: Not Connected */ PAD_NC(GPP_G5, NONE), - /* GPP_G6: Not Connected */ PAD_NC(GPP_G6, NONE), - /* GPP_G7: Not Connected */ PAD_NC(GPP_G7, NONE), }; diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index bfcd0769c0..34b67af6a6 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -81,96 +81,58 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* Data */ PAD_CFG_GPO(GPP_E8, 1, DEEP), /* DRAM Sleep */ - /* GPD2: LAN Wake */ PAD_NC(GPD2, NONE), - /* GPD6: Sleep A */ PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ PAD_CFG_GPO(GPD7, 0, PWROK), /* GPD9: Wireless LAN Sleep */ PAD_CFG_NF(GPD9, NONE, DEEP, NF1), - /* GPD10: Sleep S5 */ PAD_NC(GPD10, NONE), - /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE), - /* A5: Not Connected */ PAD_NC(GPP_A5, NONE), - /* A6: Not Connected */ PAD_NC(GPP_A6, NONE), - /* A7: Embedded Controller SCI */ PAD_NC(GPP_A7, NONE), - /* A8: Not Connected */ PAD_NC(GPP_A8, NONE), - /* A11: Not Connected */ PAD_NC(GPP_A11, NONE), - /* A12: PCH M.2 SSD PEDET */ PAD_NC(GPP_A12, NONE), - /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), - /* A15: Test Point 52 */ PAD_NC(GPP_A15, NONE), - /* A16: USB OverCurrent 3 */ PAD_NC(GPP_A16, NONE), - /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), - /* A19: Not Connected */ PAD_NC(GPP_A19, NONE), - /* A20: Test Point 44 */ PAD_NC(GPP_A20, NONE), - /* A21: Fingerprint Reader Interrupt */ PAD_NC(GPP_A21, NONE), - /* A22: Fingerprint Reader Reset */ PAD_NC(GPP_A22, NONE), - /* A23: Not Connected */ PAD_NC(GPP_A23, NONE), - /* B3: Not Connected */ PAD_NC(GPP_B3, NONE), - /* B4: Not Connected */ PAD_NC(GPP_B4, NONE), - /* B5: I2C 2 SDA Touch Panel SDA */ PAD_NC(GPP_B5, NONE), - /* B6: I2C 2 SCL Touch Panel Clock */ PAD_NC(GPP_B6, NONE), - /* B7: I2C 3 SDA Test Point 15 */ PAD_NC(GPP_B7, NONE), - /* B8: I2C 3 SCL Test Point 16 */ PAD_NC(GPP_B8, NONE), - /* B9: Not Connected */ PAD_NC(GPP_B9, NONE), - /* B10: Not Connected */ PAD_NC(GPP_B10, NONE), - /* B12: PM SLP S0 */ PAD_NC(GPP_B12, NONE), /* B14: Top Swap Override Weak Internal PD 20K High: Enabled Low: Disabled */ PAD_NC(GPP_B14, NONE), - /* B15: Not Connected */ PAD_NC(GPP_B15, NONE), - /* B16: Not Connected */ PAD_NC(GPP_B16, NONE), - /* B17: Not Connected */ PAD_NC(GPP_B17, NONE), /* B18: Reboot Support Weak Internal PD 20K High: Disabled Low: Enabled */ PAD_NC(GPP_B18, NONE), - /* B19: Not Connected */ PAD_NC(GPP_B19, NONE), - /* B20: Not Connected */ PAD_NC(GPP_B20, NONE), - /* B21: Not Connected */ PAD_NC(GPP_B21, NONE), - /* B22: Not Connected */ PAD_NC(GPP_B22, NONE), - /* B23: Not used MiPi Camera */ PAD_NC(GPP_B23, NONE), - /* B24: Not Connected */ PAD_NC(GPP_B24, NONE), - /* B25: Not Connected */ PAD_NC(GPP_B25, NONE), /* C2: TLS Confidentiality Weak Internal PD 20K @@ -185,252 +147,139 @@ const struct pad_config gpio_table[] = { Low: ESPI High: Disabled */ PAD_CFG_GPO(GPP_C5, 0, DEEP), - /* C8: Not Connected */ PAD_NC(GPP_C8, NONE), - /* C9: Not Connected */ PAD_NC(GPP_C9, NONE), - /* C10: Not Connected */ PAD_NC(GPP_C10, NONE), - /* C11: Not Connected */ PAD_NC(GPP_C11, NONE), - /* C12: Not Connected */ PAD_NC(GPP_C12, NONE), - /* C13: Not Connected */ PAD_NC(GPP_C13, NONE), - /* C14: Not Connected */ PAD_NC(GPP_C14, NONE), - /* C15: Not Connected */ PAD_NC(GPP_C15, NONE), - /* C16: Not Connected */ PAD_NC(GPP_C16, NONE), - /* C17: Not Connected */ PAD_NC(GPP_C17, NONE), - /* C18: Not Connected */ PAD_NC(GPP_C18, NONE), - /* C19: Not Connected */ PAD_NC(GPP_C19, NONE), - /* C20: Not Connected */ PAD_NC(GPP_C20, NONE), - /* C21: Not Connected */ PAD_NC(GPP_C21, NONE), - /* C22: Not Connected */ PAD_NC(GPP_C22, NONE), - /* C23: Not Connected */ PAD_NC(GPP_C23, NONE), - /* D0: Not used Audio ID 0 */ PAD_NC(GPP_D0, NONE), - /* D1: Not used Audio ID 1 */ PAD_NC(GPP_D1, NONE), - /* D2: Not used Audio ID 2 */ PAD_NC(GPP_D2, NONE), - /* D3: Not Connected */ PAD_NC(GPP_D3, NONE), - /* D4: Not Connected */ PAD_NC(GPP_D4, NONE), - /* D5: Clock Request 0 */ - PAD_NC(GPP_D5, NONE), - /* D6: Clock Request 1 PCH M.2 SSD */ + PAD_NC(GPP_D3, NONE), PAD_NC(GPP_D6, NONE), - /* D8: Clock Request 3 LAN */ PAD_NC(GPP_D8, NONE), - /* D9: GSPI 2 FPS */ PAD_NC(GPP_D9, NONE), - /* D10: GSPI 2 Clock */ PAD_NC(GPP_D10, NONE), - /* D11: GSPI 2 MISO FPS */ PAD_NC(GPP_D11, NONE), - /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), - /* D13: Wireless LAN Wake */ PAD_NC(GPP_D13, NONE), - /* D15: Not Connected */ PAD_NC(GPP_D15, NONE), - /* D16: PCH M.2 SSD Power Enable */ PAD_NC(GPP_D16, NONE), - /* D17: Not used Fingerprint ID */ PAD_NC(GPP_D17, NONE), - /* D18: Not Connected */ PAD_NC(GPP_D18, NONE), - /* D19: Test Point 21 */ PAD_NC(GPP_D19, NONE), - /* E0: SATA x PCIe */ PAD_NC(GPP_E0, NONE), - /* E1: Not used Accelerometer Interrupt */ PAD_NC(GPP_E1, NONE), - /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), /* E4: Retimer Force Power */ PAD_CFG_GPO(GPP_E4, 0, DEEP), - /* E5: Not Connected */ PAD_NC(GPP_E5, NONE), /* E6: JTAG ODT No internal PD Low: Disabled High: Enabled */ PAD_CFG_GPO(GPP_E6, 0, DEEP), - /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), - /* E9: USB OverCurrent 0 */ PAD_NC(GPP_E9, NONE), - /* E10: PWD Amplifier Input */ PAD_NC(GPP_E10, NONE), - /* E13: Not connected */ PAD_NC(GPP_E13, NONE), - /* E15: Not Connected */ PAD_NC(GPP_E15, NONE), - /* E16: Not Connected */ PAD_NC(GPP_E16, NONE), - /* E17: Not Connected */ PAD_NC(GPP_E17, NONE), - /* E18: Thunderbolt LSX TXD */ PAD_NC(GPP_E18, NONE), - /* E19: Thunderbolt LSX RXD */ PAD_NC(GPP_E19, NONE), - /* E20: Not Connected */ PAD_NC(GPP_E20, NONE), - /* E21: Not Connected */ PAD_NC(GPP_E21, NONE), - /* E22: Not Connected */ PAD_NC(GPP_E22, NONE), - /* E23: Not Connected */ PAD_NC(GPP_E23, NONE), - /* F0: CNV BRI Data */ PAD_NC(GPP_F0, NONE), - /* F1: CNV BRI Response */ PAD_NC(GPP_F1, NONE), - /* F2: CNV RGI Data */ PAD_NC(GPP_F2, NONE), - /* F3: CNV RGI Response */ PAD_NC(GPP_F3, NONE), - /* F4: CNV RF Reset */ PAD_NC(GPP_F4, NONE), - /* F5: Not used MODEM_CLKREQ */ PAD_NC(GPP_F5, NONE), - /* F6: CNV PA Blanking */ PAD_NC(GPP_F6, NONE), /* F7: TBT LSX VCCIO Weak Internal PD 20K Low: 1.8V High: 3.3V */ PAD_CFG_GPO(GPP_F7, 0, DEEP), - /* F8: Not Connected */ PAD_NC(GPP_F8, NONE), - /* F9: EC Sleep S0 */ PAD_NC(GPP_F9, NONE), /* F10: Weak Internal PD 20K */ PAD_CFG_GPO(GPP_F10, 0, PLTRST), - /* F11: TPM ID */ PAD_NC(GPP_F11, NONE), - /* F12: Not Connected */ PAD_NC(GPP_F12, NONE), - /* F13: Not Connected */ PAD_NC(GPP_F13, NONE), - /* F14: Not Connected */ PAD_NC(GPP_F14, NONE), - /* F15: Not used Accelerometer Interrupt 2*/ PAD_NC(GPP_F15, NONE), - /* F16: Not Connected */ PAD_NC(GPP_F16, NONE), - /* F17: Not used Touch Panel Reset */ PAD_NC(GPP_F17, NONE), - /* F18: Not used Touch Panel Interrupt */ PAD_NC(GPP_F18, NONE), - /* F19: Not Connected */ PAD_NC(GPP_F19, NONE), - /* F21: GPPC_F21 */ PAD_NC(GPP_F21, NONE), - /* F22: Not Connected */ PAD_NC(GPP_F22, NONE), - /* F23: Not Connected */ PAD_NC(GPP_F23, NONE), - /* H0: PCH M.2 SSD Reset */ PAD_NC(GPP_H0, NONE), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ PAD_CFG_GPO(GPP_H1, 0, DEEP), - /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), - /* H6: Not Connected */ PAD_NC(GPP_H6, NONE), - /* H7: Not Connected */ PAD_NC(GPP_H7, NONE), - /* H8: I2C 4 SDA GSensor */ PAD_NC(GPP_H8, NONE), - /* H9: I2C 4 SDL GSensor */ PAD_NC(GPP_H9, NONE), - /* H12: Not Connected */ PAD_NC(GPP_H12, NONE), - /* H13: PCH M.2 SSD Device Sleep */ PAD_NC(GPP_H13, NONE), - /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), - /* H16: Not Connected */ PAD_NC(GPP_H16, NONE), - /* H20: Not Connected */ PAD_NC(GPP_H20, NONE), - /* H21: Not Connected */ PAD_NC(GPP_H21, NONE), - /* H22: Not Connected */ PAD_NC(GPP_H22, NONE), - /* H23: Clock Request 5 */ PAD_NC(GPP_H23, NONE), - /* S0: Not Connected */ PAD_NC(GPP_S0, NONE), - /* S1: Not Connected */ PAD_NC(GPP_S1, NONE), - /* S2: DMIC Clock */ PAD_NC(GPP_S2, NONE), - /* S3: DMIC Data */ PAD_NC(GPP_S3, NONE), - /* S4: Not Connected */ PAD_NC(GPP_S4, NONE), - /* S5: Not Connected */ PAD_NC(GPP_S5, NONE), - /* S6: Not Connected */ PAD_NC(GPP_S6, NONE), - /* S7: Not Connected */ PAD_NC(GPP_S7, NONE), - /* T0: Not Connected */ PAD_NC(GPP_T0, NONE), - /* T1: Not Connected */ PAD_NC(GPP_T1, NONE), - /* T2: Not Connected */ PAD_NC(GPP_T2, NONE), - /* T3: Not Connected */ PAD_NC(GPP_T3, NONE), - /* T4: Not Connected */ PAD_NC(GPP_T4, NONE), - /* T5: Not Connected */ PAD_NC(GPP_T5, NONE), - /* T6: Not Connected */ PAD_NC(GPP_T6, NONE), - /* T7: Not Connected */ PAD_NC(GPP_T7, NONE), - /* T8: Not Connected */ PAD_NC(GPP_T8, NONE), - /* T9: Not Connected */ PAD_NC(GPP_T9, NONE), - /* T10: Not Connected */ PAD_NC(GPP_T10, NONE), - /* T11: Not Connected */ PAD_NC(GPP_T11, NONE), - /* T12: Not Connected */ PAD_NC(GPP_T12, NONE), - /* T13: Not Connected */ PAD_NC(GPP_T13, NONE), - /* T14: Not Connected */ PAD_NC(GPP_T14, NONE), - /* T15: Not Connected */ PAD_NC(GPP_T15, NONE), - /* R5: MiPi Cam Reset */ PAD_NC(GPP_R5, NONE), - /* R6: Not Connected */ PAD_NC(GPP_R6, NONE), - /* R7: Not Connected */ PAD_NC(GPP_R7, NONE), }; diff --git a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c index 4d66d40880..448683ce28 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/gpio.c @@ -212,7 +212,6 @@ const struct pad_config gpio_table[] = { PAD_NC(GPP_F22, NONE), PAD_NC(GPP_F23, NONE), - /* H3: Not Connected */ PAD_NC(GPP_H3, NONE), PAD_NC(GPP_H4, NONE), PAD_NC(GPP_H5, NONE),