From 90a5942254e50a85f022e3f2bfaf99efe68a0812 Mon Sep 17 00:00:00 2001 From: Luca Lai Date: Mon, 26 Jan 2026 10:28:53 +0800 Subject: [PATCH] mb/fatcat/var/ruby: Remove rtd3 setting I checked with the EE team. The previous status was neither D3hot nor D3cold; it was in idle state, with power consumption around 1W. With the locally tested BIOS that includes this change, the system now enters D3hot and the power consumption is reduced to about 0.4W, achieving the power-saving goal. BUG=b:475990377 BRANCH=none TEST=Build and boot to OS, check the code change could obtain power saving. Change-Id: Ib407e68dc70509e4431d87993597cd096dc0d9bc Signed-off-by: Luca Lai Reviewed-on: https://review.coreboot.org/c/coreboot/+/90907 Reviewed-by: YH Lin Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) --- src/mainboard/google/fatcat/variants/ruby/overridetree.cb | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/mainboard/google/fatcat/variants/ruby/overridetree.cb b/src/mainboard/google/fatcat/variants/ruby/overridetree.cb index 0ad94b8912..f2a4e75198 100644 --- a/src/mainboard/google/fatcat/variants/ruby/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/ruby/overridetree.cb @@ -265,13 +265,6 @@ chip soc/intel/pantherlake .clk_req = 6, .flags = PCIE_RP_CLK_REQ_DETECT | PCIE_RP_LTR | PCIE_RP_AER, }" - chip soc/intel/common/block/pcie/rtd3 - register "is_storage" = "true" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B16)" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B09)" - register "srcclk_pin" = "6" - device generic 0 on end - end end # Gen4 M.2 SSD device ref cnvi_wifi on