From 8f1c54685ae9b8f928e910f4d3fa06bb34cc4e2b Mon Sep 17 00:00:00 2001 From: Yang Wu Date: Tue, 14 Oct 2025 19:49:36 +0800 Subject: [PATCH] drivers/mipi: Fix pixel clock and enable C-PHY for TM_TL121BVMS07_00C Commit ddf5987c1e ("drivers/mipi: Add support for TM_TL121BVMS07_00C panel") (CB:89216) added support for the TM_TL121BVMS07_00C panel, but the screen was not functional. Decrease the pixel clock from 4,400,560 Hz to 264,355 Hz to match the actual panel timing specification. Also, the panel uses C-PHY interface, so enable the `PANEL_FLAG_CPHY` flag accordingly. Datasheet: Preliminary+specification+TL121BVMS07+-00+V01+20250721.pdf BUG=b:428854543 TEST=build and check firmware screen. BRANCH=skywalker Change-Id: I88fa5215d7596926aa95a58ae91dd6ade793388b Signed-off-by: Yang Wu Reviewed-on: https://review.coreboot.org/c/coreboot/+/89568 Reviewed-by: Yidi Lin Reviewed-by: Paul Menzel Reviewed-by: Yu-Ping Wu Tested-by: build bot (Jenkins) --- src/drivers/mipi/panel-TM_TL121BVMS07_00C.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/drivers/mipi/panel-TM_TL121BVMS07_00C.c b/src/drivers/mipi/panel-TM_TL121BVMS07_00C.c index 22f6d87a42..e69d8ebc54 100644 --- a/src/drivers/mipi/panel-TM_TL121BVMS07_00C.c +++ b/src/drivers/mipi/panel-TM_TL121BVMS07_00C.c @@ -9,7 +9,7 @@ struct panel_serializable_data TM_TL121BVMS07_00C = { .panel_bits_per_color = 8, .panel_bits_per_pixel = 24, .mode = { - .pixel_clock = 4400560, + .pixel_clock = 264355, .lvds_dual_channel = 0, .refresh = 60, .ha = 1600, .hbl = 44, .hso = 20, .hspw = 4, @@ -35,4 +35,5 @@ struct panel_serializable_data TM_TL121BVMS07_00C = { PANEL_DELAY(20), PANEL_END, }, + .flags = PANEL_FLAG_CPHY, };