From 8ece648c301df69f8cf0bed18b44344ecd9ab8fd Mon Sep 17 00:00:00 2001 From: Kapil Porwal Date: Mon, 15 Dec 2025 18:03:28 +0530 Subject: [PATCH] soc/qualcomm/common: Use bitwise OR for global_attributes Ensure that existing flags in global_attributes are not overwritten when enabling UART logging. Using a bitwise OR preserves any previously set attributes. BUG=b:457566143 TEST=Verify the QcLib global attributes. With this CL - ``` [DEBUG] Global Attributes[0x3]..Table Entries Count[8] ``` Change-Id: Iffceb06cb800ba4c9e5c07381745cbed1fb7d550 Signed-off-by: Kapil Porwal Reviewed-on: https://review.coreboot.org/c/coreboot/+/90509 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) --- src/soc/qualcomm/common/qclib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/qualcomm/common/qclib.c b/src/soc/qualcomm/common/qclib.c index 41239d4b57..8dad95715d 100644 --- a/src/soc/qualcomm/common/qclib.c +++ b/src/soc/qualcomm/common/qclib.c @@ -213,7 +213,7 @@ static void qclib_prepare_and_run(void) /* Enable QCLib serial output, if below condition is met */ if (CONFIG(CONSOLE_SERIAL) && qclib_debug_log_level()) - qclib_cb_if_table.global_attributes = + qclib_cb_if_table.global_attributes |= QCLIB_GA_ENABLE_UART_LOGGING; dump_te_table();