erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/google/trulo/var/pujjolo: Add tablet mode fw config for ish fw

Browse source 
Use fw config bit 15 to identify different ish files when enable
or disable tablet mode.

TABLET_ENABLE  : pujjolo_ish.bin
TABLET_DISABLE : lite_ish.bin

BUG=b:432649211
TEST=Build and boot to OS, check pujjolo and pujjoquince load
corresponding ish file using command ectool --name=cros_ish version
and test warmboot/coldboot/suspend pass.

Change-Id: Iffaadd5c772be6306cdcec08385de90c089f0489
Signed-off-by: Luca Lai <luca.lai@lcfc.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/89215
Reviewed-by: Eric Lai <ericllai@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Derek Huang <derekhuang@google.com>
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
This commit is contained in:
Luca Lai 2025-09-17 13:39:34 +08:00 • committed by Matt DeVillier
commit 8e9ec16f45
1 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/mainboard/google/brya/variants/pujjolo/overridetree.cb
View file

@ -4,6 +4,10 @@ fw_config
option LTE_PRESENT 1
option 5G_PRESENT 2
end
field TABLET_MODE 15
option TABLET_MODE_DISABLE 0
option TABLET_MODE_ENABLE 1
end
field WIFI_SAR_ID 17 20
option WIFI_SAR_TABLE_PUJJOLO_AX211 0
option WIFI_SAR_TABLE_PUJJOLO_BE200 1
@ -26,10 +30,6 @@ fw_config
option WFC_ABSENT 0
option WFC_MIPI_OVTI8856 1
end
field ISH 29
option ISH_ABSENT 0
option ISH_PRESENT 1
end
end
chip soc/intel/alderlake
@ -516,17 +516,17 @@ chip soc/intel/alderlake
end
device ref ish on
chip drivers/intel/ish
register "add_acpi_dma_property" = "true"
register "firmware_name" = ""pujjolo_ish.bin""
register "add_acpi_dma_property" = "true"
device generic 1 on
probe ISH ISH_PRESENT
probe TABLET_MODE TABLET_MODE_ENABLE
end
end
chip drivers/intel/ish
register "add_acpi_dma_property" = "true"
register "firmware_name" = ""lite_ish.bin""
register "add_acpi_dma_property" = "true"
device generic 0 on
probe ISH ISH_ABSENT
probe TABLET_MODE TABLET_MODE_DISABLE
end
end
end