erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/mediatek/mt8196: Correct assert conditions

Browse source 
Correct the assert conditions in dptx_hal_setswing_preemphasis() and
dptx_hal_phy_set_swing_preemphasis().

BRANCH=rauru
BUG=b:376357839
TEST=Verify FW screen with a 4 lanes panel on Hylia

Change-Id: I8830b05c976ea2ba987de6333b93e2394d3403ba
Signed-off-by: Yidi Lin <yidilin@chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/86302
Reviewed-by: Yu-Ping Wu <yupingso@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Yidi Lin 2025-02-06 18:12:34 +08:00
commit 8deb8e94ad
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/soc/mediatek/mt8196/dptx_hal.c
View file

@ -87,7 +87,7 @@ bool dptx_hal_hpd_high(struct mtk_dp *mtk_dp)
bool dptx_hal_setswing_preemphasis(struct mtk_dp *mtk_dp, int lane_num, u8 swing_value,
u8 preemphasis)
{
assert(lane_num < DPTX_LANE_MAX);
assert(lane_num <= DPTX_LANE_MAX);
for (int i = 0; i < lane_num; ++i) {
mtk_dp_phy_mask(mtk_dp, driving_offset[i],
@ -348,7 +348,7 @@ void dptx_hal_set_txlane(struct mtk_dp *mtk_dp, u8 value)
void dptx_hal_phy_set_swing_preemphasis(struct mtk_dp *mtk_dp, u8 lane_count, u8 *swing_val,
u8 *preemphasis)
{
assert(lane_count < DPTX_LANE_MAX);
assert(lane_count <= DPTX_LANE_MAX);
for (int i = 0; i < lane_count; ++i) {
mtk_dp_phy_mask(mtk_dp, driving_offset[i],