erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/siemens/mc_ehl{2...5}: Fix return in variant_mainboard_final()

Browse source 
If no resource is found for a device, do not return directly, otherwise
the following code will no longer be executed.

Change-Id: Ida8019c383df4be2d37a1532a1759086e86124e6
Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/85891
Reviewed-by: Uwe Poeche <uwe.poeche@siemens.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
This commit is contained in:
Mario Scheithauer 2025-01-08 08:33:32 +01:00 • committed by Werner Zeh
commit 8d4a8c5045
4 changed files with 33 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/mainboard/siemens/mc_ehl/variants/mc_ehl2/mainboard.c
View file

@ -42,22 +42,21 @@ void variant_mainboard_final(void)
dev = pcidev_path_on_root(PCH_DEVFN_SDCARD);
if (dev) {
struct resource *res = probe_resource(dev, PCI_BASE_ADDRESS_0);
if (!res)
return;
if (res) {
disable_sdr_modes(res);
disable_sdr_modes(res);
/* Use preset driver strength from preset value registers. */
clrsetbits16(res2mmio(res, HOSTCTRL2, 0), 0, HOSTCTRL2_PRESET);
/* Use preset driver strength from preset value
registers. */
clrsetbits16(res2mmio(res, HOSTCTRL2, 0), 0,
HOSTCTRL2_PRESET);
}
}
dev = pcidev_path_on_root(PCH_DEVFN_EMMC);
if (dev) {
struct resource *res = probe_resource(dev, PCI_BASE_ADDRESS_0);
if (!res)
return;
disable_sdr_modes(res);
if (res)
disable_sdr_modes(res);
}
}

13
src/mainboard/siemens/mc_ehl/variants/mc_ehl3/mainboard.c
View file

@ -33,13 +33,14 @@ void variant_mainboard_final(void)
dev = pcidev_path_on_root(PCH_DEVFN_SDCARD);
if (dev) {
struct resource *res = probe_resource(dev, PCI_BASE_ADDRESS_0);
if (!res)
return;
if (res) {
disable_sdr_modes(res);
disable_sdr_modes(res);
/* Use preset driver strength from preset value registers. */
clrsetbits16(res2mmio(res, HOSTCTRL2, 0), 0, HOSTCTRL2_PRESET);
/* Use preset driver strength from preset value
registers. */
clrsetbits16(res2mmio(res, HOSTCTRL2, 0), 0,
HOSTCTRL2_PRESET);
}
}
}

13
src/mainboard/siemens/mc_ehl/variants/mc_ehl4/mainboard.c
View file

@ -32,12 +32,13 @@ void variant_mainboard_final(void)
dev = pcidev_path_on_root(PCH_DEVFN_SDCARD);
if (dev) {
struct resource *res = probe_resource(dev, PCI_BASE_ADDRESS_0);
if (!res)
return;
if (res) {
disable_sdr_modes(res);
disable_sdr_modes(res);
/* Use preset driver strength from preset value registers. */
clrsetbits16(res2mmio(res, HOSTCTRL2, 0), 0, HOSTCTRL2_PRESET);
/* Use preset driver strength from preset value
registers. */
clrsetbits16(res2mmio(res, HOSTCTRL2, 0), 0,
HOSTCTRL2_PRESET);
}
}
}

19
src/mainboard/siemens/mc_ehl/variants/mc_ehl5/mainboard.c
View file

@ -42,22 +42,21 @@ void variant_mainboard_final(void)
dev = pcidev_path_on_root(PCH_DEVFN_SDCARD);
if (dev) {
struct resource *res = probe_resource(dev, PCI_BASE_ADDRESS_0);
if (!res)
return;
if (res) {
disable_sdr_modes(res);
disable_sdr_modes(res);
/* Use preset driver strength from preset value registers. */
clrsetbits16(res2mmio(res, HOSTCTRL2, 0), 0, HOSTCTRL2_PRESET);
/* Use preset driver strength from preset value
registers. */
clrsetbits16(res2mmio(res, HOSTCTRL2, 0), 0,
HOSTCTRL2_PRESET);
}
}
dev = pcidev_path_on_root(PCH_DEVFN_EMMC);
if (dev) {
struct resource *res = probe_resource(dev, PCI_BASE_ADDRESS_0);
if (!res)
return;
disable_sdr_modes(res);
if (res)
disable_sdr_modes(res);
}
}