erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lib/trace: Remove TRACE support

Browse source 
Looks like the option is generally not compatible with
garbage collections.

Nothing gets inlined, for example is_smp_boot() no longer
evaluates to constant false and thus the symbols from
secondary.S would need to be present for the build to pass
even if we set SMP=n.

Also the addresses of relocatable ramstage are currently
not normalised on the logs, so util/genprof would be unable
dress those.

Change-Id: I0b6f310e15e6f4992cd054d288903fea8390e5cf
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45757
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Kyösti Mälkki 2020-07-24 15:54:31 +03:00 • committed by Nico Huber
commit 8c99c27df1
14 changed files with 1 additions and 256 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/include/trace.h
View file

@ -1,28 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#ifndef __TRACE_H
#define __TRACE_H
#if !ENV_ROMSTAGE_OR_BEFORE && CONFIG(TRACE)
void __cyg_profile_func_enter(void *, void *)
__attribute__((no_instrument_function));
void __cyg_profile_func_exit(void *, void *)
__attribute__((no_instrument_function));
extern volatile int trace_dis;
#define DISABLE_TRACE do { trace_dis = 1; } while (0);
#define ENABLE_TRACE do { trace_dis = 0; } while (0);
#define DISABLE_TRACE_ON_FUNCTION __attribute__((no_instrument_function));
#else /* !CONFIG_TRACE */
#define DISABLE_TRACE
#define ENABLE_TRACE
#define DISABLE_TRACE_ON_FUNCTION
#endif
#endif