From 8ba58ef800aa899feada62c0562f3f64857934cf Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Thu, 26 Feb 2026 08:20:05 -0600 Subject: [PATCH] mb/samsung/lumpy: Correct NID 0x08 HDA pin config macro usage Commit eb504eb49ab7 ("mb/samsung/lumpy: Fix HDA pin configuration issues") incorrectly used AZALIA_PIN_CFG_NC(0) as a standalone entry for NID 0x08. Change to AZALIA_PIN_CFG(0, 0x08, AZALIA_PIN_CFG_NC(0)) so the verb for NID 0x08 is emitted correctly. Change-Id: Iaf23b6e8791a352758189d92ad9c89414fc5a22d Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/91442 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/mainboard/samsung/lumpy/hda_verb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/samsung/lumpy/hda_verb.c b/src/mainboard/samsung/lumpy/hda_verb.c index aedd7b6ce2..e6ed443a95 100644 --- a/src/mainboard/samsung/lumpy/hda_verb.c +++ b/src/mainboard/samsung/lumpy/hda_verb.c @@ -56,7 +56,7 @@ const u32 cim_verb_data[] = { )), /* Pin Complex (NID 0x08) - Unused (NC) */ - AZALIA_PIN_CFG_NC(0), + AZALIA_PIN_CFG(0, 0x08, AZALIA_PIN_CFG_NC(0)), /* Pin Complex (NID 0x09) - Internal Digital Mic */ AZALIA_PIN_CFG(0, 0x09, AZALIA_PIN_DESC(