From 8b5442820072d04cd4705be784345d1f272c4296 Mon Sep 17 00:00:00 2001 From: Zhongtian Wu Date: Thu, 5 Jun 2025 20:52:10 +0800 Subject: [PATCH] mb/google/nissa: Override GPIO_PCH_WP for pujjocento variant According to the circuit schematic diagram, pujjocento uses GPP_E12 as a write-protected gpio,so it is necessary to add the GPIO_PCH_WP definition for GPP_E12 in gpio.h. BUG=b:422656149 BRANCH=none TEST=wp status update verified by toggling it on and off. Change-Id: I91081f1b0ce5cb2fb3a29b96c1dcc18774f70f09 Signed-off-by: Zhongtian Wu Reviewed-on: https://review.coreboot.org/c/coreboot/+/87967 Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai Reviewed-by: Subrata Banik Reviewed-by: Kapil Porwal --- src/mainboard/google/brya/variants/pujjocento/gpio.c | 2 +- .../google/brya/variants/pujjocento/include/variant/gpio.h | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/brya/variants/pujjocento/gpio.c b/src/mainboard/google/brya/variants/pujjocento/gpio.c index e079b19981..517eb495b4 100644 --- a/src/mainboard/google/brya/variants/pujjocento/gpio.c +++ b/src/mainboard/google/brya/variants/pujjocento/gpio.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -#include +#include #include #include #include diff --git a/src/mainboard/google/brya/variants/pujjocento/include/variant/gpio.h b/src/mainboard/google/brya/variants/pujjocento/include/variant/gpio.h index 66cfef0274..351bb879c3 100644 --- a/src/mainboard/google/brya/variants/pujjocento/include/variant/gpio.h +++ b/src/mainboard/google/brya/variants/pujjocento/include/variant/gpio.h @@ -4,6 +4,9 @@ #define VARIANT_GPIO_H #include +#undef GPIO_PCH_WP +/* WP signal to PCH */ +#define GPIO_PCH_WP GPP_E12 #define WWAN_FCPO GPP_D6 /* FULL_CARD_POWER_OFF# */ #define WWAN_RST GPP_E17