erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc/intel/pantherlake: Keep default values for TdcTimeWindow

Browse source 
This patch prevents coreboot from overwriting FSP defaults with zeros
for unconfigured VR domains.

Ref=:830097_WCL_PDG_SchChk_Rev1p5
BUG=b:None
TEST=Build ocelot and verify that the system boots with correct
VR parameter
[SPEW ]   TdcTimeWindow[0]:0x6D60
[SPEW ]   TdcTimeWindow[1]:0x0
[SPEW ]   TdcTimeWindow[2]:0x0
[SPEW ]   TdcTimeWindow[3]:0x0
[SPEW ]   Override TdcTimeWindow[0] = 28000
[SPEW ]   Override TdcTimeWindow[1] = 1000
[SPEW ]   Override TdcTimeWindow[2] = 0
[SPEW ]   Override TdcTimeWindow[3] = 1000

FSP defaults:
[SPEW ]   Override TdcTimeWindow[0] = 28000
[SPEW ]   Override TdcTimeWindow[1] = 1000
[SPEW ]   Override TdcTimeWindow[2] = 0
[SPEW ]   Override TdcTimeWindow[3] = 1000

Added print in the coreboot code
[DEBUG]  VR[0]: Setting TdcTimeWindow to 28000
[DEBUG]  VR[1]: Setting TdcTimeWindow to 0
[DEBUG]  VR[2]: Setting TdcTimeWindow to 0
[DEBUG]  VR[3]: Setting TdcTimeWindow to 0

Change-Id: Ib2531b908ddf80c40c52f620229852487d3425e9
Signed-off-by: Sowmya Aralguppe <sowmya.aralguppe@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/91503
Reviewed-by: Pranava Y N <pranavayn@google.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Subrata Banik <subratabanik@google.com>
This commit is contained in:
Sowmya Aralguppe 2026-03-02 13:33:48 +05:30 • committed by Matt DeVillier
commit 8aa0ea4062
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/soc/intel/pantherlake/romstage/fsp_params.c
View file

@ -366,8 +366,10 @@ static void fill_fspm_vr_config_params(FSP_M_CONFIG *m_cfg,
} }
for (size_t i = 0; i < ARRAY_SIZE(config->tdc_mode); i++) { for (size_t i = 0; i < ARRAY_SIZE(config->tdc_mode); i++) {
m_cfg->TdcMode[i] = config->tdc_mode[i]; if (config->tdc_mode[i])
m_cfg->TdcTimeWindow[i] = config->tdc_time_window_ms[i]; m_cfg->TdcMode[i] = config->tdc_mode[i];
if (config->tdc_time_window_ms[i])
m_cfg->TdcTimeWindow[i] = config->tdc_time_window_ms[i];
} }
for (size_t i = 0; i < ARRAY_SIZE(config->ps1_threshold); i++) { for (size_t i = 0; i < ARRAY_SIZE(config->ps1_threshold); i++) {