erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

cpu/intel/microcode: Add error handling if microcode directory is empty

Browse source 
If the directory specified by CONFIG_CPU_INTEL_UCODE_SPLIT_BINARIES does
not contain any files, no build error will occur, and resulting coreboot
image will not include any microcode.

BUG=None
TEST="src/cpu/intel/microcode/Makefile.mk:16: *** "microcode-params is
empty. Ensure CONFIG_CPU_INTEL_UCODE_SPLIT_BINARIES is set correctly and
contains valid files.".  Stop."

Change-Id: I095d9a24cb473b528d85bf8325c06fd3dc055b74
Signed-off-by: Simon Yang <simon1.yang@intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87636
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jérémy Compostella <jeremy.compostella@intel.com>
This commit is contained in:
Simon Yang 2025-05-12 12:34:34 +08:00 • committed by Matt DeVillier
commit 8a4b3e1346
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/cpu/intel/microcode/Makefile.mk
View file

@ -11,6 +11,11 @@ ifeq ($(CONFIG_CPU_INTEL_MICROCODE_CBFS_SPLIT_BINS),y)
microcode-params-dir := $(call strip_quotes,$(CONFIG_CPU_INTEL_UCODE_SPLIT_BINARIES))/
microcode-params := $(shell find "$(microcode-params-dir)" -type f -exec basename {} \;)
# Ensure microcode-params is not empty
ifeq ($(microcode-params),)
$(error "microcode-params is empty. Ensure CONFIG_CPU_INTEL_UCODE_SPLIT_BINARIES is set correctly and contains valid files.")
endif
# Make "cpu_microcode_$(CPUID).bin" file entry into the FIT table
$(call add_intermediate, add_mcu_fit, set_fit_ptr $(IFITTOOL))
$(foreach params, $(microcode-params), $(shell $(IFITTOOL) -f $< -a -n $(params) -t 1 \