From 8961f6681f37b699827f291d3cbfa101f4bbb4b9 Mon Sep 17 00:00:00 2001 From: Jeremy Compostella Date: Tue, 3 Jun 2025 15:43:52 -0700 Subject: [PATCH] soc/intel/common/acpi/pcie_clk: Fix ACPI conditional compilation error This commit addresses a compilation error in the PCIe ClkReq SPCO method due to incorrect conditional compilation logic. The previous implementation lacked the necessary preprocessor directives to differentiate between configurations when SOC_INTEL_COMMON_BLOCK_IOE_P2SB is not defined. BUG=b:422284273 Change-Id: Ie7b70babd279f7241f6e76113a6694a5bd0d782d Signed-off-by: Jeremy Compostella Reviewed-on: https://review.coreboot.org/c/coreboot/+/87930 Reviewed-by: Wonkyu Kim Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik Reviewed-by: Kapil Porwal --- src/soc/intel/common/acpi/pcie_clk.asl | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/soc/intel/common/acpi/pcie_clk.asl b/src/soc/intel/common/acpi/pcie_clk.asl index e7e311fe9c..b74d601a1a 100644 --- a/src/soc/intel/common/acpi/pcie_clk.asl +++ b/src/soc/intel/common/acpi/pcie_clk.asl @@ -14,6 +14,7 @@ * Arg1: Enable(1)/Disable(0) Clock */ Method (SPCO, 2, Serialized) { +#if CONFIG(SOC_INTEL_COMMON_BLOCK_IOE_P2SB) If (LEqual (Arg1,1)) { If (LGreaterEqual (Arg0, CONFIG_IOE_DIE_CLOCK_START)) { \_SB.ECLK.CLKE (Subtract (Arg0, CONFIG_IOE_DIE_CLOCK_START)) @@ -27,4 +28,11 @@ Method (SPCO, 2, Serialized) { \_SB.ICLK.CLKD (Arg0) } } +#else + If (LEqual (Arg1,1)) { + \_SB.ICLK.CLKE (Arg0) + } Else { + \_SB.ICLK.CLKD (Arg0) + } +#endif }