From 8687b3d108180aaa6dacc0a8f20d4a8ab19a2d34 Mon Sep 17 00:00:00 2001 From: erin liang Date: Tue, 8 Jul 2025 13:38:48 +0800 Subject: [PATCH] mb/google/trulo/var/pujjolo: Add ISH firmware config Due to Pujjoquince does not have ISH, thus define bit 29 in firmware_config to indicate ISH presence per platform. BUG=b:417599885 BRANCH=none TEST= Use the command ls /dev/cros_ and no cros_ish option will appear Change-Id: I286300eadf7991d3a30936f5904ff3eef4480039 Signed-off-by: erin liang Reviewed-on: https://review.coreboot.org/c/coreboot/+/88364 Reviewed-by: Eric Lai Reviewed-by: Kapil Porwal Tested-by: build bot (Jenkins) --- .../google/brya/variants/pujjolo/overridetree.cb | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/brya/variants/pujjolo/overridetree.cb b/src/mainboard/google/brya/variants/pujjolo/overridetree.cb index c6cce61c73..c9c551025a 100644 --- a/src/mainboard/google/brya/variants/pujjolo/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjolo/overridetree.cb @@ -20,6 +20,10 @@ fw_config option WFC_ABSENT 0 option WFC_MIPI_OVTI8856 1 end + field ISH 29 + option ISH_ABSENT 0 + option ISH_PRESENT 1 + end end chip soc/intel/alderlake @@ -449,7 +453,9 @@ chip soc/intel/alderlake chip drivers/intel/ish register "add_acpi_dma_property" = "true" register "firmware_name" = ""pujjolo_ish.bin"" - device generic 0 on end + device generic 0 on + probe ISH ISH_PRESENT + end end end device ref ufs on end