ARM: Remove -mno-unaligned-access
We've decided that it is generally okay for coreboot to expect unaligned accesses to work. Trying to find all instances of unaligned access opportunities and working around them in software would be an unsustainable whack-a-mole contest. Instead, architectures and boards need to make sure they conform to this, which on ARM and ARM64 requires setting up paging early in the bootblock. Other architectures (x86, ARM64, MIPS) already generate code in this manner. ARM still had an -mno-unaligned-access flag hanging around that has been copied so many times its initial origin was lost in time (probably U-Boot). Let's remove it for consistency between architectures and to improve code generation. BRANCH=veyron BUG=None TEST=Booted Jerry and Blaze. Looked at the disassembly for timestamp_sync() and confirmed that it only gives you half as much eye cancer as before (GCC still somehow insists on byte accesses when zeroing fields which is very odd, but at least that terrible AND/OR mess is gone). Measured a boot time increase of about 11ms on Jerry (mostly faster timestamp and CBFS accesses). Could not test Storm because despite our claimed abundance of test devices, every time I get one of them it magically disappears again in less than a week. Change-Id: I1d046e05bb11822b86e467eafb6aa92e8fbce774 Signed-off-by: Julius Werner <jwerner@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/241732 Reviewed-by: Aaron Durbin <adurbin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/242162
This commit is contained in:
parent
dde230b25b
commit
8606b30d44
1 changed files with 1 additions and 1 deletions
|
|
@ -118,7 +118,7 @@ $(eval $(call create_class_compiler,arm64,aarch64))
|
|||
|
||||
CFLAGS_nonx86 += -ffunction-sections -fdata-sections -Wstack-usage=1536
|
||||
|
||||
CFLAGS_arm += $(CFLAGS_nonx86) -mno-unaligned-access
|
||||
CFLAGS_arm += $(CFLAGS_nonx86)
|
||||
|
||||
CFLAGS_arm64 += $(CFLAGS_nonx86)
|
||||
CFLAGS_mipsel += $(CFLAGS_nonx86) -mips32r2 -G 0
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue