From 85bf5d6c2fb2d227dda998e31df8fabdc15b735f Mon Sep 17 00:00:00 2001 From: Lee Leahy Date: Tue, 17 May 2016 08:40:02 -0700 Subject: [PATCH] UPSTREAM: drivers/intel/fsp2_0: Fix array indexing error Don't allow an array index of 2 to be processed by the code referencing the array. Found-by: Coverity CID 1353337 TEST=None Change-Id: I586ca14416a6e40971f8f6f4066fbdb4908ca688 Original-Signed-off-by: Lee Leahy Original-Reviewed-on: https://review.coreboot.org/14868 Original-Reviewed-by: Aaron Durbin (cherry-picked from commit 016d8f75d8aa53efad250f034c55ea8454390e99) Signed-off-by: Martin Roth Reviewed-on: https://chromium-review.googlesource.com/346521 Reviewed-by: Stefan Reinauer Commit-Queue: Stefan Reinauer Tested-by: Stefan Reinauer --- src/drivers/intel/fsp2_0/graphics.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/drivers/intel/fsp2_0/graphics.c b/src/drivers/intel/fsp2_0/graphics.c index 1480179eaa..f4ba40220f 100644 --- a/src/drivers/intel/fsp2_0/graphics.c +++ b/src/drivers/intel/fsp2_0/graphics.c @@ -1,7 +1,7 @@ /* * This file is part of the coreboot project. * - * Copyright (C) 2015 Intel Corp. + * Copyright (C) 2015 - 2016 Intel Corp. * (Written by Alexandru Gagniuc for Intel Corp.) * * This program is free software; you can redistribute it and/or modify @@ -67,7 +67,7 @@ enum cb_err fsp_fill_lb_framebuffer(struct lb_framebuffer *framebuffer) return CB_ERR; } - if (ginfo->pixel_format > ARRAY_SIZE(fsp_framebuffer_format_map)) { + if (ginfo->pixel_format >= ARRAY_SIZE(fsp_framebuffer_format_map)) { printk(BIOS_ALERT, "FSP set unknown framebuffer format: %d\n", ginfo->pixel_format); return CB_ERR;