From 850703b32b3e1ff0c0bcf5b2fe4381f508af0f2a Mon Sep 17 00:00:00 2001
From: Subrata Banik <subratabanik@google.com>
Date: Mon, 12 May 2025 15:46:20 +0530
Subject: [PATCH] mb/google/bluey: Configure FPMCU power, reset, and QUPv3
 peripherals

Perform comprehensive peripheral initialization across romstage
and ramstage for the Bluey mainboard. This brings up essential
ChromeOS components and manages their power/reset sequences.

Key changes include:
- FPMCU Power & Reset:
  - Enable `GPIO_EN_FP_RAILS` in romstage for power rail
    stabilization (conditional on SPI fingerprint).
  - Deassert `GPIO_FP_RST_L` in ramstage once FPMCU power is stable.

- QUPv3/GPI Peripherals:
  - Load GSI (Generic Software Interface) firmware for
    QUP_0/1/2_GSI_BASE.
  - Initialize various QUPv3 Serial Engines (SE) in ramstage:
    - UART for console (if not `CONFIG_CONSOLE_SERIAL`).
    - I2C for Touch and Trackpad controllers.
    - UART for Bluetooth module.
    - SPI for the Fingerprint module (conditional on Kconfig).

- Display Initialization: Add a placeholder function `display_startup()`
  in ramstage.

BUG=b:404985109
TEST=Able to build google/bluey.

Change-Id: Iaa800e89eb521dc9d7b0a01984ca07b46a2a29d6
Signed-off-by: Subrata Banik <subratabanik@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/87643
Reviewed-by: Kapil Porwal <kapilporwal@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
 src/mainboard/google/bluey/mainboard.c | 42 +++++++++++++++++++++++++-
 src/mainboard/google/bluey/romstage.c  | 11 +++++++
 2 files changed, 52 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/bluey/mainboard.c b/src/mainboard/google/bluey/mainboard.c
index c633e8dfb1..db44fe7972 100644
--- a/src/mainboard/google/bluey/mainboard.c
+++ b/src/mainboard/google/bluey/mainboard.c
@@ -1,7 +1,13 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
+#include <bootmode.h>
+#include <console/console.h>
 #include <device/device.h>
+#include <gpio.h>
 #include <soc/pcie.h>
+#include <soc/qupv3_config_common.h>
+#include <soc/qup_se_handlers_common.h>
+#include "board.h"
 
 bool mainboard_needs_pcie_init(void)
 {
@@ -9,9 +15,43 @@ bool mainboard_needs_pcie_init(void)
 	return false;
 }
 
+static void display_startup(void)
+{
+	if (!display_init_required()) {
+		printk(BIOS_INFO, "Skipping display init.\n");
+		return;
+	}
+
+	/* TODO: add logic for display init */
+}
+
 static void mainboard_init(struct device *dev)
 {
-	/* Placeholder */
+	gpi_firmware_load(QUP_0_GSI_BASE);
+	gpi_firmware_load(QUP_1_GSI_BASE);
+	gpi_firmware_load(QUP_2_GSI_BASE);
+
+	/*
+	 * Load console UART QUP firmware.
+	 * This is required even if coreboot's serial output is disabled.
+	 */
+	if (!CONFIG(CONSOLE_SERIAL))
+		qupv3_se_fw_load_and_init(QUPV3_2_SE5, SE_PROTOCOL_UART, FIFO);
+
+	qupv3_se_fw_load_and_init(QUPV3_1_SE0, SE_PROTOCOL_I2C, MIXED); /* Touch I2C */
+	qupv3_se_fw_load_and_init(QUPV3_1_SE6, SE_PROTOCOL_UART, FIFO); /* BT UART */
+	qupv3_se_fw_load_and_init(QUPV3_0_SE0, SE_PROTOCOL_I2C, MIXED); /* Trackpad I2C */
+	if (CONFIG(MAINBOARD_HAS_FINGERPRINT_VIA_SPI))
+		qupv3_se_fw_load_and_init(QUPV3_2_SE2, SE_PROTOCOL_SPI, MIXED); /* Fingerprint SPI */
+
+	/*
+	 * Deassert FPMCU reset. Power applied in romstage
+	 * has now stabilized.
+	 */
+	if (CONFIG(MAINBOARD_HAS_FINGERPRINT))
+		gpio_output(GPIO_FP_RST_L, 1);
+
+	display_startup();
 }
 
 static void mainboard_enable(struct device *dev)
diff --git a/src/mainboard/google/bluey/romstage.c b/src/mainboard/google/bluey/romstage.c
index 8d15157e70..f6932fefdc 100644
--- a/src/mainboard/google/bluey/romstage.c
+++ b/src/mainboard/google/bluey/romstage.c
@@ -1,8 +1,19 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 
 #include <arch/stages.h>
+#include <gpio.h>
+#include "board.h"
 
 void platform_romstage_main(void)
 {
 	/* Placeholder */
+
+	/*
+	 * Enable this power rail now for FPMCU stability prior to
+	 * its reset being deasserted in ramstage. This applies
+	 * when MAINBOARD_HAS_FINGERPRINT_VIA_SPI Kconfig is enabled.
+	 * Requires >=200ms delay after its pin was driven low in bootblock.
+	 */
+	if (CONFIG(MAINBOARD_HAS_FINGERPRINT_VIA_SPI))
+		gpio_output(GPIO_EN_FP_RAILS, 1);
 }