soc/intel/*: Only skip PMC fallback on successful CSE reset
cse_request_global_reset() returns CSE_TX_RX_SUCCESS on success. Make do_global_reset() explicatly check for that, and fall back CF9 for any other value. Test=Disable and enable the Intel ME on starbook_mtl and verify the system actually resets, rather than hanging. Change-Id: I4c3fb7995bca8e7fe3793b9aee021e4004ace933 Signed-off-by: Sean Rhodes <sean@starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/90273 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
parent
4f52ca6ba6
commit
84a4cdc6a5
8 changed files with 8 additions and 8 deletions
|
|
@ -8,7 +8,7 @@
|
||||||
void do_global_reset(void)
|
void do_global_reset(void)
|
||||||
{
|
{
|
||||||
/* Ask CSE to do the global reset */
|
/* Ask CSE to do the global reset */
|
||||||
if (cse_request_global_reset())
|
if (cse_request_global_reset() == CSE_TX_RX_SUCCESS)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
/* global reset if CSE fail to reset */
|
/* global reset if CSE fail to reset */
|
||||||
|
|
|
||||||
|
|
@ -8,7 +8,7 @@
|
||||||
void do_global_reset(void)
|
void do_global_reset(void)
|
||||||
{
|
{
|
||||||
/* Ask CSE to do the global reset */
|
/* Ask CSE to do the global reset */
|
||||||
if (cse_request_global_reset())
|
if (cse_request_global_reset() == CSE_TX_RX_SUCCESS)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
/* global reset if CSE fail to reset */
|
/* global reset if CSE fail to reset */
|
||||||
|
|
|
||||||
|
|
@ -8,7 +8,7 @@
|
||||||
void do_global_reset(void)
|
void do_global_reset(void)
|
||||||
{
|
{
|
||||||
/* Ask CSE to do the global reset */
|
/* Ask CSE to do the global reset */
|
||||||
if (cse_request_global_reset())
|
if (cse_request_global_reset() == CSE_TX_RX_SUCCESS)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
/* global reset if CSE fail to reset */
|
/* global reset if CSE fail to reset */
|
||||||
|
|
|
||||||
|
|
@ -8,7 +8,7 @@
|
||||||
void do_global_reset(void)
|
void do_global_reset(void)
|
||||||
{
|
{
|
||||||
/* Ask CSE to do the global reset */
|
/* Ask CSE to do the global reset */
|
||||||
if (cse_request_global_reset())
|
if (cse_request_global_reset() == CSE_TX_RX_SUCCESS)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
/* global reset if CSE fail to reset */
|
/* global reset if CSE fail to reset */
|
||||||
|
|
|
||||||
|
|
@ -8,7 +8,7 @@
|
||||||
void do_global_reset(void)
|
void do_global_reset(void)
|
||||||
{
|
{
|
||||||
/* Ask CSE to do the global reset */
|
/* Ask CSE to do the global reset */
|
||||||
if (cse_request_global_reset())
|
if (cse_request_global_reset() == CSE_TX_RX_SUCCESS)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
/* global reset if CSE fail to reset */
|
/* global reset if CSE fail to reset */
|
||||||
|
|
|
||||||
|
|
@ -8,7 +8,7 @@
|
||||||
void do_global_reset(void)
|
void do_global_reset(void)
|
||||||
{
|
{
|
||||||
/* Ask CSE to do the global reset */
|
/* Ask CSE to do the global reset */
|
||||||
if (cse_request_global_reset())
|
if (cse_request_global_reset() == CSE_TX_RX_SUCCESS)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
/* global reset if CSE fail to reset */
|
/* global reset if CSE fail to reset */
|
||||||
|
|
|
||||||
|
|
@ -8,7 +8,7 @@
|
||||||
void do_global_reset(void)
|
void do_global_reset(void)
|
||||||
{
|
{
|
||||||
/* Ask CSE to do the global reset */
|
/* Ask CSE to do the global reset */
|
||||||
if (cse_request_global_reset())
|
if (cse_request_global_reset() == CSE_TX_RX_SUCCESS)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
/* global reset if CSE fail to reset */
|
/* global reset if CSE fail to reset */
|
||||||
|
|
|
||||||
|
|
@ -8,7 +8,7 @@
|
||||||
void do_global_reset(void)
|
void do_global_reset(void)
|
||||||
{
|
{
|
||||||
/* Ask CSE to do the global reset */
|
/* Ask CSE to do the global reset */
|
||||||
if (cse_request_global_reset())
|
if (cse_request_global_reset() == CSE_TX_RX_SUCCESS)
|
||||||
return;
|
return;
|
||||||
|
|
||||||
/* global reset if CSE fail to reset */
|
/* global reset if CSE fail to reset */
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue