From 847d91b82e5c6bb18447a8ee19c950365d4b2877 Mon Sep 17 00:00:00 2001 From: Maximilian Brune Date: Thu, 11 Dec 2025 23:34:52 +0100 Subject: [PATCH] include/acpi/acpi_apei.h: Update APEI structs for better readability Signed-off-by: Maximilian Brune Change-Id: I380c793700b3b42373df556c17718e4fd2b147d5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/90475 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- src/acpi/acpi.c | 4 ++-- src/include/acpi/acpi_apei.h | 16 ++++++++-------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index b22c4bc2c0..abdcf26160 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -648,7 +648,7 @@ void acpi_create_einj(acpi_einj_t *einj, uintptr_t addr, u8 actions) .action = SET_ERROR_TYPE_WITH_ADDRESS, .instruction = WRITE_REGISTER, .flags = FLAG_PRESERVE, - .reg = EINJ_REG_MEMORY((u64)(uintptr_t)&einj_smi->setaddrtable), + .reg = EINJ_REG_MEMORY((u64)(uintptr_t)&einj_smi->set_addr_table), .value = 1, .mask = 0xffffffff } @@ -1027,7 +1027,7 @@ unsigned long acpi_create_hest_error_source(acpi_hest_t *hest, memset(pos, 0, sizeof(acpi_hest_hen_t)); hen->type = 3; /* SCI? */ hen->length = sizeof(acpi_hest_hen_t); - hen->conf_we = 0; /* Configuration Write Enable. */ + hen->conf_write_enable = 0; hen->poll_interval = 0; hen->vector = 0; hen->sw2poll_threshold_val = 0; diff --git a/src/include/acpi/acpi_apei.h b/src/include/acpi/acpi_apei.h index 5f0b8a3a1b..3885994c25 100644 --- a/src/include/acpi/acpi_apei.h +++ b/src/include/acpi/acpi_apei.h @@ -63,7 +63,7 @@ typedef struct acpi_hest_esd { typedef struct acpi_hest_hen { u8 type; u8 length; - u16 conf_we; /* Configuration Write Enable */ + u16 conf_write_enable; u32 poll_interval; u32 vector; u32 sw2poll_threshold_val; @@ -240,13 +240,13 @@ typedef struct acpi_einj_trigger_table { } __packed acpi_einj_trigger_table_t; typedef struct set_error_type { - u32 errtype; - u32 vendorerrortype; + u32 err_type; + u32 vendor_error_type; u32 flags; - u32 apicid; - u64 memaddr; - u64 memrange; - u32 pciesbdf; + u32 apic_id; + u64 mem_addr; + u64 mem_range; + u32 pcie_sbdf; } __packed set_error_type_t; #define EINJ_PARAM_NUM 6 @@ -259,7 +259,7 @@ typedef struct acpi_einj_smi { u64 cmd_sts; u64 einj_addr; u64 einj_addr_msk; - set_error_type_t setaddrtable; + set_error_type_t set_addr_table; u64 reserved[50]; } __packed acpi_einj_smi_t;