From 80404b6b9ecc996777ce663755d568b34b892a42 Mon Sep 17 00:00:00 2001 From: Elyes Haouas Date: Tue, 7 Jan 2025 13:58:55 +0100 Subject: [PATCH] tree: Use "true", "false" for *acoustic_noise_mitigation acoustic_noise_mitigation & enable_acoustic_noise_mitigation are boolean, so use true false instead of 0, 1. Change-Id: Icb1d2743222ff5100527fc6413cc13226a087904 Signed-off-by: Elyes Haouas Reviewed-on: https://review.coreboot.org/c/coreboot/+/85880 Reviewed-by: Kapil Porwal Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- src/mainboard/google/brya/variants/anahera/overridetree.cb | 2 +- src/mainboard/google/brya/variants/anahera4es/overridetree.cb | 2 +- src/mainboard/google/brya/variants/crota/overridetree.cb | 2 +- src/mainboard/google/brya/variants/gimble/overridetree.cb | 2 +- src/mainboard/google/brya/variants/gimble4es/overridetree.cb | 2 +- src/mainboard/google/brya/variants/joxer/overridetree.cb | 2 +- src/mainboard/google/brya/variants/kano/overridetree.cb | 2 +- src/mainboard/google/brya/variants/marasov/overridetree.cb | 2 +- src/mainboard/google/brya/variants/primus/overridetree.cb | 2 +- src/mainboard/google/brya/variants/pujjo/overridetree.cb | 2 +- src/mainboard/google/brya/variants/pujjoga/overridetree.cb | 2 +- .../google/brya/variants/pujjoga/overridetree_pujjogatwin.cb | 2 +- src/mainboard/google/brya/variants/redrix/overridetree.cb | 2 +- src/mainboard/google/brya/variants/redrix4es/overridetree.cb | 2 +- src/mainboard/google/brya/variants/riven/overridetree.cb | 2 +- src/mainboard/google/brya/variants/rull/overridetree.cb | 2 +- src/mainboard/google/brya/variants/sundance/overridetree.cb | 2 +- src/mainboard/google/brya/variants/taeko/overridetree.cb | 2 +- src/mainboard/google/brya/variants/taeko4es/overridetree.cb | 2 +- src/mainboard/google/brya/variants/taniks/overridetree.cb | 2 +- src/mainboard/google/brya/variants/telith/overridetree.cb | 2 +- src/mainboard/google/brya/variants/xol/overridetree.cb | 2 +- src/mainboard/google/brya/variants/zydron/overridetree.cb | 2 +- src/mainboard/google/rex/variants/screebo/overridetree.cb | 2 +- src/mainboard/prodrive/atlas/devicetree.cb | 2 +- 25 files changed, 25 insertions(+), 25 deletions(-) diff --git a/src/mainboard/google/brya/variants/anahera/overridetree.cb b/src/mainboard/google/brya/variants/anahera/overridetree.cb index 4cc2efcc42..95787eec85 100644 --- a/src/mainboard/google/brya/variants/anahera/overridetree.cb +++ b/src/mainboard/google/brya/variants/anahera/overridetree.cb @@ -29,7 +29,7 @@ chip soc/intel/alderlake register "usb2_phy_sus_pg_disable" = "1" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb index 2e14c64a5c..33daa9962c 100644 --- a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb @@ -24,7 +24,7 @@ end chip soc/intel/alderlake register "sagv" = "SaGv_Enabled" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/crota/overridetree.cb b/src/mainboard/google/brya/variants/crota/overridetree.cb index 1facf07622..7b0fd59676 100644 --- a/src/mainboard/google/brya/variants/crota/overridetree.cb +++ b/src/mainboard/google/brya/variants/crota/overridetree.cb @@ -48,7 +48,7 @@ chip soc/intel/alderlake }" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_4" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_4" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/gimble/overridetree.cb b/src/mainboard/google/brya/variants/gimble/overridetree.cb index ce705f7bd9..314899675b 100644 --- a/src/mainboard/google/brya/variants/gimble/overridetree.cb +++ b/src/mainboard/google/brya/variants/gimble/overridetree.cb @@ -25,7 +25,7 @@ chip soc/intel/alderlake register "platform_pmax" = "143" register "tcss_aux_ori" = "1" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb index a81425be4f..802e11e4a8 100644 --- a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb @@ -25,7 +25,7 @@ chip soc/intel/alderlake register "platform_pmax" = "143" register "tcss_aux_ori" = "1" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/joxer/overridetree.cb b/src/mainboard/google/brya/variants/joxer/overridetree.cb index c12d412f59..c7849d22cd 100644 --- a/src/mainboard/google/brya/variants/joxer/overridetree.cb +++ b/src/mainboard/google/brya/variants/joxer/overridetree.cb @@ -17,7 +17,7 @@ chip soc/intel/alderlake register "sagv" = "SaGv_Enabled" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/kano/overridetree.cb b/src/mainboard/google/brya/variants/kano/overridetree.cb index 7620ddef43..6e3383eaea 100644 --- a/src/mainboard/google/brya/variants/kano/overridetree.cb +++ b/src/mainboard/google/brya/variants/kano/overridetree.cb @@ -36,7 +36,7 @@ chip soc/intel/alderlake register "pmc_gpe0_dw1" = "GPP_D" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/marasov/overridetree.cb b/src/mainboard/google/brya/variants/marasov/overridetree.cb index 57f0c90372..add5181b2f 100644 --- a/src/mainboard/google/brya/variants/marasov/overridetree.cb +++ b/src/mainboard/google/brya/variants/marasov/overridetree.cb @@ -29,7 +29,7 @@ end chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/primus/overridetree.cb b/src/mainboard/google/brya/variants/primus/overridetree.cb index c7a188281c..893b3cf062 100644 --- a/src/mainboard/google/brya/variants/primus/overridetree.cb +++ b/src/mainboard/google/brya/variants/primus/overridetree.cb @@ -31,7 +31,7 @@ chip soc/intel/alderlake register "usb2_phy_sus_pg_disable" = "1" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/pujjo/overridetree.cb b/src/mainboard/google/brya/variants/pujjo/overridetree.cb index 082d3dd999..60b35d79a3 100644 --- a/src/mainboard/google/brya/variants/pujjo/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjo/overridetree.cb @@ -55,7 +55,7 @@ end chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/pujjoga/overridetree.cb b/src/mainboard/google/brya/variants/pujjoga/overridetree.cb index 8877c41da9..e1ac962c9f 100644 --- a/src/mainboard/google/brya/variants/pujjoga/overridetree.cb +++ b/src/mainboard/google/brya/variants/pujjoga/overridetree.cb @@ -12,7 +12,7 @@ end chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/pujjoga/overridetree_pujjogatwin.cb b/src/mainboard/google/brya/variants/pujjoga/overridetree_pujjogatwin.cb index a10ae5fb16..ba70a31abb 100644 --- a/src/mainboard/google/brya/variants/pujjoga/overridetree_pujjogatwin.cb +++ b/src/mainboard/google/brya/variants/pujjoga/overridetree_pujjogatwin.cb @@ -12,7 +12,7 @@ end chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb index 6a35fc6216..f26d133461 100644 --- a/src/mainboard/google/brya/variants/redrix/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb @@ -42,7 +42,7 @@ chip soc/intel/alderlake register "fivr_spread_spectrum" = "FIVR_SS_6" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb index 3a1ae7634d..01574421bd 100644 --- a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb @@ -37,7 +37,7 @@ chip soc/intel/alderlake register "fivr_spread_spectrum" = "FIVR_SS_6" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/riven/overridetree.cb b/src/mainboard/google/brya/variants/riven/overridetree.cb index 6f8db3c0ac..359c4275df 100644 --- a/src/mainboard/google/brya/variants/riven/overridetree.cb +++ b/src/mainboard/google/brya/variants/riven/overridetree.cb @@ -25,7 +25,7 @@ end chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_4" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_4" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/rull/overridetree.cb b/src/mainboard/google/brya/variants/rull/overridetree.cb index 3c04da5dac..77c85b2c24 100644 --- a/src/mainboard/google/brya/variants/rull/overridetree.cb +++ b/src/mainboard/google/brya/variants/rull/overridetree.cb @@ -13,7 +13,7 @@ end chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "true" diff --git a/src/mainboard/google/brya/variants/sundance/overridetree.cb b/src/mainboard/google/brya/variants/sundance/overridetree.cb index 03450d40c2..8782f5d225 100644 --- a/src/mainboard/google/brya/variants/sundance/overridetree.cb +++ b/src/mainboard/google/brya/variants/sundance/overridetree.cb @@ -10,7 +10,7 @@ end chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/taeko/overridetree.cb b/src/mainboard/google/brya/variants/taeko/overridetree.cb index 13d883652c..964d83309b 100644 --- a/src/mainboard/google/brya/variants/taeko/overridetree.cb +++ b/src/mainboard/google/brya/variants/taeko/overridetree.cb @@ -53,7 +53,7 @@ chip soc/intel/alderlake register "usb2_phy_sus_pg_disable" = "1" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb index bbaa0ca586..2dc3287a05 100644 --- a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb +++ b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb @@ -40,7 +40,7 @@ fw_config end chip soc/intel/alderlake # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/taniks/overridetree.cb b/src/mainboard/google/brya/variants/taniks/overridetree.cb index 807f40a6b4..ebe5853283 100644 --- a/src/mainboard/google/brya/variants/taniks/overridetree.cb +++ b/src/mainboard/google/brya/variants/taniks/overridetree.cb @@ -41,7 +41,7 @@ chip soc/intel/alderlake register "usb2_phy_sus_pg_disable" = "1" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/telith/overridetree.cb b/src/mainboard/google/brya/variants/telith/overridetree.cb index cac770f868..8784e2f533 100644 --- a/src/mainboard/google/brya/variants/telith/overridetree.cb +++ b/src/mainboard/google/brya/variants/telith/overridetree.cb @@ -21,7 +21,7 @@ chip soc/intel/alderlake register "sagv" = "SaGv_Enabled" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/xol/overridetree.cb b/src/mainboard/google/brya/variants/xol/overridetree.cb index 71e89deb1c..69209fa731 100644 --- a/src/mainboard/google/brya/variants/xol/overridetree.cb +++ b/src/mainboard/google/brya/variants/xol/overridetree.cb @@ -15,7 +15,7 @@ chip soc/intel/alderlake }" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_4" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_4" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/brya/variants/zydron/overridetree.cb b/src/mainboard/google/brya/variants/zydron/overridetree.cb index b02cb0738c..0acf4906c8 100644 --- a/src/mainboard/google/brya/variants/zydron/overridetree.cb +++ b/src/mainboard/google/brya/variants/zydron/overridetree.cb @@ -36,7 +36,7 @@ chip soc/intel/alderlake register "pmc_gpe0_dw1" = "GPP_D" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" diff --git a/src/mainboard/google/rex/variants/screebo/overridetree.cb b/src/mainboard/google/rex/variants/screebo/overridetree.cb index e79cf8ca92..d46d7c91ef 100644 --- a/src/mainboard/google/rex/variants/screebo/overridetree.cb +++ b/src/mainboard/google/rex/variants/screebo/overridetree.cb @@ -97,7 +97,7 @@ chip soc/intel/meteorlake # slew rate for IA Domain: Fast/8 # slew rate for GT Domain: Fast/8 # Ignore slew rate configuration for SA Domain - register "enable_acoustic_noise_mitigation" = "1" + register "enable_acoustic_noise_mitigation" = "true" register "disable_fast_pkgc_ramp[VR_DOMAIN_IA]" = "1" register "slow_slew_rate_config[VR_DOMAIN_IA]" = "SLEW_FAST_8" register "disable_fast_pkgc_ramp[VR_DOMAIN_GT]" = "1" diff --git a/src/mainboard/prodrive/atlas/devicetree.cb b/src/mainboard/prodrive/atlas/devicetree.cb index baca59d576..9afdda5f6c 100644 --- a/src/mainboard/prodrive/atlas/devicetree.cb +++ b/src/mainboard/prodrive/atlas/devicetree.cb @@ -31,7 +31,7 @@ chip soc/intel/alderlake }" # Acoustic settings - register "acoustic_noise_mitigation" = "1" + register "acoustic_noise_mitigation" = "true" register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_4" register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_4" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1"