erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

sb/i82801ix: Use macros instead of hard-coded IDs

Browse source 
This patch replaces hard-coded PCI IDs with macros
from pci_ids.h and cleans up some code.

Change-Id: Ie6ea72ac49eb015ef5cbaa98ed2b3400072000b5
Signed-off-by: Felix Singer <felix.singer@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36705
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Singer 2019-11-10 11:04:08 +01:00 • committed by Patrick Georgi
commit 7f8b0cd89c
9 changed files with 36 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/include/device/pci_ids.h
View file

@ -2546,13 +2546,15 @@
#define PCI_DEVICE_ID_INTEL_82801HEM_LPC 0x2811
/* Intel 82801IB (ICH9) */
#define PCI_DEVICE_ID_INTEL_82801IB_LPC 0x2918
#define PCI_DEVICE_ID_INTEL_82801IB_LPC 0x2918 /* ICH9 */
#define PCI_DEVICE_ID_INTEL_82801IB_SATA_P0123 0x2920 /* Ports 0 - 3 */
#define PCI_DEVICE_ID_INTEL_82801IB_SATA_P01 0x2921 /* Ports 0 - 1 */
#define PCI_DEVICE_ID_INTEL_82801IB_SATA_AHCI1 0x2922 /* Ports 0 - 5 */
#define PCI_DEVICE_ID_INTEL_82801IB_SATA_AHCI2 0x2923 /* Ports 0, 1, 4, 5 */
#define PCI_DEVICE_ID_INTEL_82801IB_SATA_RAID 0x2822 /* RAID */
#define PCI_DEVICE_ID_INTEL_82801IB_SATA_P45 0x2926 /* Ports 4 - 5 */
#define PCI_DEVICE_ID_INTEL_82801IBM_IEM_SATA_IDE_P01 0x2928 /* Ports 0 - 1 */
#define PCI_DEVICE_ID_INTEL_82801IBM_IEM_SATA_AHCI_P0145 0x2929 /* Ports 0, 1, 4, 5 */
#define PCI_DEVICE_ID_INTEL_82801IB_SMB 0x2930
#define PCI_DEVICE_ID_INTEL_82801IB_THERMAL 0x2932
#define PCI_DEVICE_ID_INTEL_82801IB_PCI 0x244e /* DMI to PCI bridge */
@ -2573,10 +2575,12 @@
#define PCI_DEVICE_ID_INTEL_82801IB_PCIE6 0x294a
#define PCI_DEVICE_ID_INTEL_82801IB_LAN 0x29c4
/* Intel 82801IR/IH/IO (ICH9R/ICH9DH/ICH9DO), only difference to ICH9: LPC */
#define PCI_DEVICE_ID_INTEL_82801IR_LPC 0x2916
#define PCI_DEVICE_ID_INTEL_82801IO_LPC 0x2914
#define PCI_DEVICE_ID_INTEL_82801IH_LPC 0x2912
/* Only difference to ICH9: LPC */
#define PCI_DEVICE_ID_INTEL_82801IH_LPC 0x2912 /* ICH9DH */
#define PCI_DEVICE_ID_INTEL_82801IO_LPC 0x2914 /* ICH9DO */
#define PCI_DEVICE_ID_INTEL_82801IR_LPC 0x2916 /* ICH9R */
#define PCI_DEVICE_ID_INTEL_82801IEM_LPC 0x2917 /* ICH9M-E */
#define PCI_DEVICE_ID_INTEL_82801IBM_LPC 0x2919 /* ICH9M */
#define PCI_DEVICE_ID_INTEL_CAVECREEK_LPC 0x2310
#define PCI_DEVICE_ID_INTEL_COUGARPOINT_LPC_MIN 0x1c41