From 7e172ca4fd394772d6f62e19f25285a0b0b5cdc3 Mon Sep 17 00:00:00 2001 From: Youness Alaoui Date: Mon, 27 Feb 2017 12:03:39 -0500 Subject: [PATCH] UPSTREAM: intel/broadwell: Use the correct SATA port config for setting IOBP register Fix a typo that was introduce in commit 696ebc2d (Broadwell/Sata: Add support for setting IOBP registers for Ports 2 and 3.) [1]. Setting one of the SATA port 3 IOBP setting was using the value from the port 2 register. On the purism/librem13 (on which SATA port 3 is tested), this change doesn't seem to affect anything, as that typo wasn't exhibiting any visible problems anyways. [1] https://review.coreboot.org/18408 BUG=none BRANCH=none TEST=none Change-Id: I872b03d4d4d28ae77d1cfe315da6a336c555817b Signed-off-by: Patrick Georgi Original-Commit-Id: 601aa313a6b8f5a6055c20a8105118c46a81a28b Original-Change-Id: I3948def5c0588791009c4b24cbc061552d9d1d48 Original-Signed-off-by: Youness Alaoui Original-Reviewed-on: https://review.coreboot.org/18514 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Duncan Laurie Original-Reviewed-by: Philippe Mathieu-Daud Original-Reviewed-by: Paul Menzel Reviewed-on: https://chromium-review.googlesource.com/449825 --- src/soc/intel/broadwell/sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/broadwell/sata.c b/src/soc/intel/broadwell/sata.c index 1f2e690c25..7b9bd0cd07 100644 --- a/src/soc/intel/broadwell/sata.c +++ b/src/soc/intel/broadwell/sata.c @@ -161,7 +161,7 @@ static void sata_init(struct device *dev) pch_iobp_update(SATA_IOBP_SP3_SECRT88, ~(SATA_SECRT88_VADJ_MASK << SATA_SECRT88_VADJ_SHIFT), - (config->sata_port2_gen3_tx & + (config->sata_port3_gen3_tx & SATA_SECRT88_VADJ_MASK) << SATA_SECRT88_VADJ_SHIFT);