erebion/coreboot
Watch
1
0
Fork
You've already forked coreboot
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/starlabs/*: Correct PAD ownership

Browse source 
Commit `57aca97a2c` correctly changed the
reset types of GPIOs used in ACPI, but incorrectly set the pads to GPIO
mode, rather than ACPI mode.

This patch corrects that.

Change-Id: I7207d4d00e810c15d071eca0bea83796989e3735
Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/86344
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Sean Rhodes 2025-02-10 14:35:37 +00:00
commit 7d7802088a
9 changed files with 42 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c
View file

@ -63,7 +63,7 @@ const struct pad_config gpio_table[] = {
/* A12: PCH M.2 SSD PEDET */
PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
/* A13: BlueTooth RF Kill */
PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_A13, 1, DEEP),
/* A14: Type C VBUS OverCurrent */
PAD_CFG_NF(GPP_A14, NONE, DEEP, NF1),
/* A15: Test Point 3 */
@ -229,7 +229,7 @@ const struct pad_config gpio_table[] = {
/* D15: Not Connected */
PAD_NC(GPP_D15, NONE),
/* D16: PCH M.2 SSD Power Enable */
PAD_CFG_GPO_GPIO_DRIVER(GPP_D16, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_D16, 1, DEEP),
/* D17: Not Connected */
PAD_NC(GPP_D17, NONE),
/* D18: Not Connected */
@ -244,7 +244,7 @@ const struct pad_config gpio_table[] = {
/* E2: Not Connected */
PAD_NC(GPP_E2, NONE),
/* E3: WiFi RF Kill */
PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_E3, 1, DEEP),
/* E4: Test Point 7 */
PAD_NC(GPP_E4, NONE),
/* E5: Not Connected */
@ -340,7 +340,7 @@ const struct pad_config gpio_table[] = {
PAD_NC(GPP_F23, NONE),
/* H0: PCH M.2 SSD Reset */
PAD_CFG_GPO_GPIO_DRIVER(GPP_H0, 1, PLTRST, NONE),
PAD_CFG_GPO(GPP_H0, 1, PLTRST),
/* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */
PAD_CFG_GPO(GPP_H1, 0, DEEP),
/* H2: Wireless LAN Reset */
@ -452,7 +452,7 @@ const struct pad_config gpio_table[] = {
PAD_NC(GPP_R7, NONE),
/* BT_EN */
PAD_CFG_GPO_GPIO_DRIVER(GPP_VGPIO_0, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_VGPIO_0, 1, DEEP),
/* CNVi BT UART0 */
PAD_NC(GPP_VGPIO_6, NONE),

10
src/mainboard/starlabs/starbook/variants/adl/gpio.c
View file

@ -63,7 +63,7 @@ const struct pad_config gpio_table[] = {
/* A12: PCH M.2 SSD PEDET */
PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
/* A13: BlueTooth RF Kill */
PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_A13, 1, DEEP),
/* A14: Test Point 45 */
PAD_NC(GPP_A14, NONE),
/* A15: Test Point 52 */
@ -228,7 +228,7 @@ const struct pad_config gpio_table[] = {
/* D15: Not Connected */
PAD_NC(GPP_D15, NONE),
/* D16: PCH M.2 SSD Power Enable */
PAD_CFG_GPO_GPIO_DRIVER(GPP_D16, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_D16, 1, DEEP),
/* D17: Not used Fingerprint ID */
PAD_NC(GPP_D17, NONE),
/* D18: Not Connected */
@ -243,7 +243,7 @@ const struct pad_config gpio_table[] = {
/* E2: Not Connected */
PAD_NC(GPP_E2, NONE),
/* E3: WiFi RF Kill */
PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_E3, 1, DEEP),
/* E4: Test Point 14 */
PAD_NC(GPP_E4, NONE),
/* E5: Not Connected */
@ -339,11 +339,11 @@ const struct pad_config gpio_table[] = {
PAD_NC(GPP_F23, NONE),
/* H0: PCH M.2 SSD Reset */
PAD_CFG_GPO_GPIO_DRIVER(GPP_H0, 1, PLTRST, NONE),
PAD_CFG_GPO(GPP_H0, 1, PLTRST),
/* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */
PAD_CFG_GPO(GPP_H1, 0, DEEP),
/* H2: Wireless LAN Reset */
PAD_CFG_GPO_GPIO_DRIVER(GPP_H2, 1, PLTRST, NONE),
PAD_CFG_GPO(GPP_H2, 1, PLTRST),
/* H3: Not Connected */
PAD_NC(GPP_H3, NONE),
/* H4: I2C 0 SDA Touchpad */

10
src/mainboard/starlabs/starbook/variants/adl_n/gpio.c
View file

@ -63,7 +63,7 @@ const struct pad_config gpio_table[] = {
/* A12: Not Connected */
PAD_NC(GPP_A12, NONE),
/* A13: BlueTooth RF Kill */
PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_A13, 1, DEEP),
/* A14: Test Point 45 */
PAD_NC(GPP_A14, NONE),
/* A15: Test Point 52 */
@ -228,7 +228,7 @@ const struct pad_config gpio_table[] = {
/* D15: Not Connected */
PAD_NC(GPP_D15, NONE),
/* D16: PCH M.2 SSD Power Enable */
PAD_CFG_GPO_GPIO_DRIVER(GPP_D16, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_D16, 1, DEEP),
/* D17: Not used Fingerprint ID */
PAD_NC(GPP_D17, NONE),
/* D18: Not Connected */
@ -243,7 +243,7 @@ const struct pad_config gpio_table[] = {
/* E2: Not Connected */
PAD_NC(GPP_E2, NONE),
/* E3: WiFi RF Kill */
PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_E3, 1, DEEP),
/* E4: Test Point 14 */
PAD_NC(GPP_E4, NONE),
/* E5: Not Connected */
@ -339,11 +339,11 @@ const struct pad_config gpio_table[] = {
PAD_NC(GPP_F23, NONE),
/* H0: PCH M.2 SSD Reset */
PAD_CFG_GPO_GPIO_DRIVER(GPP_H0, 1, PLTRST, NONE),
PAD_CFG_GPO(GPP_H0, 1, PLTRST),
/* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */
PAD_CFG_GPO(GPP_H1, 0, DEEP),
/* H2: Wireless LAN Reset */
PAD_CFG_GPO_GPIO_DRIVER(GPP_H2, 1, PLTRST, NONE),
PAD_CFG_GPO(GPP_H2, 1, PLTRST),
/* H3: Not Connected */
PAD_NC(GPP_H3, NONE),
/* H4: I2C 0 SDA Touchpad */

4
src/mainboard/starlabs/starbook/variants/cml/gpio.c
View file

@ -116,7 +116,7 @@ const struct pad_config gpio_table[] = {
/* B3: CLICK_PAD_INT_R_N */
PAD_CFG_GPI_APIC_LOW(GPP_B3, NONE, PLTRST),
/* B4: BT_RF_KILL_N */
PAD_CFG_GPO_GPIO_DRIVER(GPP_B4, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_B4, 1, DEEP),
/* B5: WLAN_CLKREQ# */
PAD_CFG_NF(GPP_B5, NONE, DEEP, NF1),
/* B6: CLKREQ1_SSD_N */
@ -161,7 +161,7 @@ const struct pad_config gpio_table[] = {
/* C1: SMB_DATA */
PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1),
/* C2: WIFI_RF_KILL_N */
PAD_CFG_GPO_GPIO_DRIVER(GPP_C2, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_C2, 1, DEEP),
/* C3: Not Connected */
PAD_NC(GPP_C3, NONE),
/* C4: Not Connected */

10
src/mainboard/starlabs/starbook/variants/mtl/gpio.c
View file

@ -249,14 +249,14 @@ const struct pad_config gpio_table[] = {
* End: GPP_H23
*/
/* H00: M.2_PCH_SSD_RESET_N */
PAD_CFG_GPO_GPIO_DRIVER(GPP_H00, 1, PLTRST, NONE),
PAD_CFG_GPO(GPP_H00, 1, PLTRST),
/* H01: FLASH RECOVERY
* HIGH: ENABLED
* LOW: DISABLED
* WEAK INTERNAL PD 20K */
PAD_NC(GPP_H01, NONE),
/* H02: WLAN_RST_N */
PAD_CFG_GPO_GPIO_DRIVER(GPP_H02, 1, PLTRST, NONE),
PAD_CFG_GPO(GPP_H02, 1, PLTRST),
/* H03: */
PAD_NC(GPP_H03, NONE),
/* H04: */
@ -266,7 +266,7 @@ const struct pad_config gpio_table[] = {
/* H06: */
PAD_NC(GPP_H06, NONE),
/* H07: M.2_CPU_SSD_PWREN */
PAD_CFG_GPO_GPIO_DRIVER(GPP_H07, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_H07, 1, DEEP),
/* H08: */
PAD_NC(GPP_H08, NONE),
/* H09: */
@ -432,9 +432,9 @@ const struct pad_config gpio_table[] = {
/* B17: */
PAD_NC(GPP_B17, NONE),
/* B18: BT_RF_KILL_N */
PAD_CFG_GPO_GPIO_DRIVER(GPP_B18, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_B18, 1, DEEP),
/* B19: WIFI_RF_KILL_N */
PAD_CFG_GPO_GPIO_DRIVER(GPP_B19, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_B19, 1, DEEP),
/* B20: */
PAD_NC(GPP_B20, NONE),
/* B21: */

10
src/mainboard/starlabs/starbook/variants/rpl/gpio.c
View file

@ -63,7 +63,7 @@ const struct pad_config gpio_table[] = {
/* A12: PCH M.2 SSD PEDET */
PAD_NC(GPP_A12, NONE),
/* A13: BlueTooth RF Kill */
PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_A13, 1, DEEP),
/* A14: Test Point 45 */
PAD_NC(GPP_A14, NONE),
/* A15: Test Point 52 */
@ -224,7 +224,7 @@ const struct pad_config gpio_table[] = {
/* D13: Wireless LAN Wake */
PAD_NC(GPP_D13, NONE),
/* D14: CPU M.2 SSD Power Enable */
PAD_CFG_GPO_GPIO_DRIVER(GPP_D14, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_D14, 1, DEEP),
/* D15: Not Connected */
PAD_NC(GPP_D15, NONE),
/* D16: PCH M.2 SSD Power Enable */
@ -243,9 +243,9 @@ const struct pad_config gpio_table[] = {
/* E2: Not Connected */
PAD_NC(GPP_E2, NONE),
/* E3: WiFi RF Kill */
PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_E3, 1, DEEP),
/* E4: Retimer Force Power */
PAD_CFG_GPO_GPIO_DRIVER(GPP_E4, 0, DEEP, NONE),
PAD_CFG_GPO(GPP_E4, 0, DEEP),
/* E5: Not Connected */
PAD_NC(GPP_E5, NONE),
/* E6: JTAG ODT No internal PD
@ -330,7 +330,7 @@ const struct pad_config gpio_table[] = {
/* F19: Not Connected */
PAD_NC(GPP_F19, NONE),
/* F20: CPU M.2 SSD Reset */
PAD_CFG_GPO_GPIO_DRIVER(GPP_F20, 1, PLTRST, NONE),
PAD_CFG_GPO(GPP_F20, 1, PLTRST),
/* F21: GPPC_F21 */
PAD_NC(GPP_F21, NONE),
/* F22: Not Connected */

6
src/mainboard/starlabs/starbook/variants/tgl/gpio.c
View file

@ -66,7 +66,7 @@ const struct pad_config gpio_table[] = {
/* A10: WLAN_PCM_IN */
PAD_NC(GPP_A10, NONE),
/* A11: M2_CPU_SSD_RST_N */
PAD_CFG_GPO_GPIO_DRIVER(GPP_A11, 1, PLTRST, NONE),
PAD_CFG_GPO(GPP_A11, 1, PLTRST),
/* A12: SATAGP_1 */
PAD_CFG_NF(GPP_A12, UP_20K, DEEP, NF1),
/* A13: Not Connected */
@ -90,7 +90,7 @@ const struct pad_config gpio_table[] = {
/* A22: Not Connected */
PAD_NC(GPP_A22, NONE),
/* A23: TC_RETIMER_FORCE_PWR */
PAD_CFG_GPO_GPIO_DRIVER(GPP_A23, 0, DEEP, NONE),
PAD_CFG_GPO(GPP_A23, 0, DEEP),
/* B0: CORE_VID_0 */
PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1),
@ -219,7 +219,7 @@ const struct pad_config gpio_table[] = {
/* D15: Not Connected */
PAD_NC(GPP_D15, NONE),
/* D16: CPU_SSD_PWREN */
PAD_CFG_GPO_GPIO_DRIVER(GPP_D16, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_D16, 1, DEEP),
/* D17: Not Connected */
PAD_NC(GPP_D17, NONE),
/* D18: Not Connected */

12
src/mainboard/starlabs/starfighter/variants/rpl/gpio.c
View file

@ -72,7 +72,7 @@ const struct pad_config gpio_table[] = {
/* A12: PCH M.2 SSD PEDET */
PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1),
/* A13: BlueTooth RF Kill */
PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_A13, 1, DEEP),
/* A14: Test Point 45 */
PAD_NC(GPP_A14, NONE),
/* A15: Test Point 52 */
@ -229,7 +229,7 @@ const struct pad_config gpio_table[] = {
/* D13: Wireless LAN Wake */
PAD_NC(GPP_D13, NONE),
/* D14: CPU M.2 SSD Power Enable */
PAD_CFG_GPO_GPIO_DRIVER(GPP_D14, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_D14, 1, DEEP),
/* D15: Not Connected */
PAD_NC(GPP_D15, NONE),
/* D16: PCH M.2 SSD Power Enable */
@ -248,9 +248,9 @@ const struct pad_config gpio_table[] = {
/* E2: Not Connected */
PAD_NC(GPP_E2, NONE),
/* E3: WiFi RF Kill */
PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_E3, 1, DEEP),
/* E4: Retimer Force Power */
PAD_CFG_GPO_GPIO_DRIVER(GPP_E4, 0, DEEP, NONE),
PAD_CFG_GPO(GPP_E4, 0, DEEP),
/* E5: Not Connected */
PAD_NC(GPP_E5, NONE),
/* E6: JTAG ODT No internal PD
@ -327,7 +327,7 @@ const struct pad_config gpio_table[] = {
/* F19: Not Connected */
PAD_NC(GPP_F19, NONE),
/* F20: CPU M.2 SSD Reset */
PAD_CFG_GPO_GPIO_DRIVER(GPP_F20, 1, PLTRST, NONE),
PAD_CFG_GPO(GPP_F20, 1, PLTRST),
/* F21: GPPC_F21 */
PAD_NC(GPP_F21, NONE),
/* F22: Not Connected */
@ -340,7 +340,7 @@ const struct pad_config gpio_table[] = {
/* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */
PAD_CFG_GPO(GPP_H1, 0, DEEP),
/* H2: Wireless LAN Reset */
PAD_CFG_GPO_GPIO_DRIVER(GPP_H2, 1, PLTRST, NONE),
PAD_CFG_GPO(GPP_H2, 1, PLTRST),
/* H3: Not Connected */
PAD_NC(GPP_H3, NONE),
/* H4: I2C 0 SDA Touchpad */

12
src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c
View file

@ -63,7 +63,7 @@ const struct pad_config gpio_table[] = {
/* A12: Not Connected */
PAD_NC(GPP_A12, NONE),
/* A13: BlueTooth RF Kill */
PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_A13, 1, DEEP),
/* A14: Camera Power Enable */
PAD_NC(GPP_A14, NONE),
/* A15: Camera Reset */
@ -227,7 +227,7 @@ const struct pad_config gpio_table[] = {
/* D15: Not Connected */
PAD_NC(GPP_D15, NONE),
/* D16: PCH M.2 SSD Power Enable */
PAD_CFG_GPO_GPIO_DRIVER(GPP_D16, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_D16, 1, DEEP),
/* D17: Not used Fingerprint ID */
PAD_NC(GPP_D17, NONE),
/* D18: Bluetooth Wake */
@ -242,7 +242,7 @@ const struct pad_config gpio_table[] = {
/* E2: Not Connected */
PAD_NC(GPP_E2, NONE),
/* E3: WiFi RF Kill */
PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_E3, 1, DEEP),
/* E4: P Offset */
PAD_NC(GPP_E4, NONE),
/* E5: P Out */
@ -323,7 +323,7 @@ const struct pad_config gpio_table[] = {
/* F16: Not Connected */
PAD_NC(GPP_F16, NONE),
/* F17: Touch Panel Reset */
PAD_CFG_GPO_GPIO_DRIVER(GPP_F17, 1, PLTRST, NONE),
PAD_CFG_GPO(GPP_F17, 1, PLTRST),
/* F18: Touch Panel Interrupt */
PAD_CFG_GPI_APIC(GPP_F18, NONE, PLTRST, LEVEL, INVERT),
/* F19: Not Connected */
@ -338,7 +338,7 @@ const struct pad_config gpio_table[] = {
PAD_NC(GPP_F23, NONE),
/* H0: PCH M.2 SSD Reset */
PAD_CFG_GPO_GPIO_DRIVER(GPP_H0, 1, PLTRST, NONE),
PAD_CFG_GPO(GPP_H0, 1, PLTRST),
/* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */
PAD_CFG_GPO(GPP_H1, 0, DEEP),
/* H2: Wireless LAN Reset */
@ -450,7 +450,7 @@ const struct pad_config gpio_table[] = {
PAD_NC(GPP_R7, NONE),
/* BT_EN */
PAD_CFG_GPO_GPIO_DRIVER(GPP_VGPIO_0, 1, DEEP, NONE),
PAD_CFG_GPO(GPP_VGPIO_0, 1, DEEP),
/* CNVi BT UART0 */
PAD_NC(GPP_VGPIO_6, NONE),