From 7cd7db69913f6e7582e1495c1169ba6ba8e4b44f Mon Sep 17 00:00:00 2001 From: Naresh Solanki Date: Wed, 20 Nov 2024 14:55:48 +0530 Subject: [PATCH] soc/amd/common/psp_gen2: Add config for PSP MBOX offset Some SoC like Glinda use different PSP MBOX offset. Add config to allow SoC Kconfig to override PSP MBOX offset. Change-Id: Iefcc7d3b75689b43399a7a7b612417c155619211 Signed-off-by: Naresh Solanki Reviewed-on: https://review.coreboot.org/c/coreboot/+/85626 Reviewed-by: Ana Carolina Cabral Tested-by: build bot (Jenkins) Reviewed-by: Felix Held --- src/soc/amd/common/block/psp/Kconfig | 4 ++++ src/soc/amd/common/block/psp/psp_gen2.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/soc/amd/common/block/psp/Kconfig b/src/soc/amd/common/block/psp/Kconfig index 07ee0fa47d..17853faccf 100644 --- a/src/soc/amd/common/block/psp/Kconfig +++ b/src/soc/amd/common/block/psp/Kconfig @@ -202,3 +202,7 @@ config USE_AMDFWTOOL default y if SOC_AMD_COMMON_BLOCK_PSP help Select this if AMDFWTOOL needs to be built + +config PSPV2_MBOX_CMD_OFFSET + hex + default 0x10570 diff --git a/src/soc/amd/common/block/psp/psp_gen2.c b/src/soc/amd/common/block/psp/psp_gen2.c index 21c1f2a735..026d32f086 100644 --- a/src/soc/amd/common/block/psp/psp_gen2.c +++ b/src/soc/amd/common/block/psp/psp_gen2.c @@ -8,8 +8,8 @@ #include #include "psp_def.h" -#define PSP_MAILBOX_COMMAND_OFFSET 0x10570 /* 4 bytes */ -#define PSP_MAILBOX_BUFFER_OFFSET 0x10574 /* 8 bytes */ +#define PSP_MAILBOX_COMMAND_OFFSET CONFIG_PSPV2_MBOX_CMD_OFFSET /* 4 bytes */ +#define PSP_MAILBOX_BUFFER_OFFSET (CONFIG_PSPV2_MBOX_CMD_OFFSET + 4) /* 8 bytes */ #define IOHC_MISC_PSP_MMIO_REG 0x2e0