erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

mb/starlabs: Drop explicit devtree_update calls

Browse source 
devtree_update() is invoked automatically at BS_PRE_DEVICE. Remove the
per-board init_mainboard() calls and associated includes.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
Change-Id: Ifb44080dc2e785a8554f5404902540daa9e872d1
Reviewed-on: https://review.coreboot.org/c/coreboot/+/90990
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
This commit is contained in:
Sean Rhodes 2026-02-15 21:13:00 +00:00
commit 7bee4f5efb
5 changed files with 3 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/mainboard/starlabs/byte_adl/mainboard.c
View file

@ -2,7 +2,6 @@
#include <device/device.h>
#include <soc/ramstage.h>
#include <option.h>
#include <variants.h>
static void init_mainboard(void *chip_info)
@ -12,8 +11,6 @@ static void init_mainboard(void *chip_info)
pads = variant_gpio_table(&num);
gpio_configure_pads(pads, num);
devtree_update();
}
struct chip_operations mainboard_ops = {

2
src/mainboard/starlabs/lite/mainboard.c
View file

@ -11,8 +11,6 @@ static void init_mainboard(void *chip_info)
pads = variant_gpio_table(&num);
gpio_configure_pads(pads, num);
devtree_update();
}
struct chip_operations mainboard_ops = {

2
src/mainboard/starlabs/starbook/mainboard.c
View file

@ -13,8 +13,6 @@ static void init_mainboard(void *chip_info)
pads = variant_gpio_table(&num);
gpio_configure_pads(pads, num);
devtree_update();
}
struct chip_operations mainboard_ops = {

3
src/mainboard/starlabs/starfighter/mainboard.c
View file

@ -2,7 +2,6 @@
#include <device/device.h>
#include <soc/ramstage.h>
#include <option.h>
#include <variants.h>
static void init_mainboard(void *chip_info)
@ -12,8 +11,6 @@ static void init_mainboard(void *chip_info)
pads = variant_gpio_table(&num);
gpio_configure_pads(pads, num);
devtree_update();
}
struct chip_operations mainboard_ops = {

12
src/mainboard/starlabs/starlite_adl/mainboard.c
View file

@ -3,7 +3,6 @@
#include <acpi/acpigen_ps2_keybd.h>
#include <device/device.h>
#include <soc/ramstage.h>
#include <option.h>
#include <variants.h>
static void init_mainboard(void *chip_info)
@ -13,18 +12,13 @@ static void init_mainboard(void *chip_info)
pads = variant_gpio_table(&num);
gpio_configure_pads(pads, num);
devtree_update();
}
static void mainboard_fill_ssdt(const struct device *dev)
{
enum ps2_action_key ps2_action_keys[2] = {
PS2_KEY_VOL_DOWN,
PS2_KEY_VOL_UP
};
acpigen_ps2_keyboard_dsd("_SB.PCI0.PS2K", ARRAY_SIZE(ps2_action_keys),
ps2_action_keys, false, false, false, false, false);
enum ps2_action_key ps2_action_keys[2] = {PS2_KEY_VOL_DOWN, PS2_KEY_VOL_UP};
acpigen_ps2_keyboard_dsd("_SB.PCI0.PS2K", ARRAY_SIZE(ps2_action_keys), ps2_action_keys,
false, false, false, false, false);
}
static void enable_mainboard(struct device *dev)