From 7b6bbb7ef51db8849723adb414459def72f57533 Mon Sep 17 00:00:00 2001 From: Yu-Ping Wu Date: Tue, 21 Jan 2025 15:39:37 +0800 Subject: [PATCH] soc/mediatek: Fix register access for EINT We should be writing to the address of reg[i], instead of the address whose value is reg[i]. Change-Id: I4fb78f974155725a91aad3a5450733d24b57af15 Signed-off-by: Yu-Ping Wu Reviewed-on: https://review.coreboot.org/c/coreboot/+/86073 Tested-by: build bot (Jenkins) Reviewed-by: Yidi Lin --- src/soc/mediatek/common/eint_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/mediatek/common/eint_event.c b/src/soc/mediatek/common/eint_event.c index 6e44b37192..be13d55f0f 100644 --- a/src/soc/mediatek/common/eint_event.c +++ b/src/soc/mediatek/common/eint_event.c @@ -17,7 +17,7 @@ static void enable_eint_event(const struct eint_event_info *event) int i; for (i = 0; i < port; i++) - write32p(reg[i], EINT_VALUE); + write32(®[i], EINT_VALUE); } void unmask_eint_event_mask(void)