From 7a58cfff897ada03b4c3e9996d14881b3c623fc4 Mon Sep 17 00:00:00 2001 From: Yidi Lin Date: Fri, 11 Apr 2025 10:38:36 +0800 Subject: [PATCH] util/scripts/update_submodules: Fix "branch: unbound variable" error After CB:86803, ${branch} variable is no longer valid. Use ${branch_name} instead ${branch} for generating the commit message. TEST=./util/scripts/update_submodules -R 3rdparty/arm-trusted-firmware/ The script generates the new commit successfully. Change-Id: Ia528379b8721e6d419984bab28de7cf427e42423 Signed-off-by: Yidi Lin Reviewed-on: https://review.coreboot.org/c/coreboot/+/87268 Reviewed-by: Elyes Haouas Reviewed-by: Yu-Ping Wu Tested-by: build bot (Jenkins) --- util/scripts/update_submodules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/scripts/update_submodules b/util/scripts/update_submodules index cbf2364ebe..9eeb3836e6 100755 --- a/util/scripts/update_submodules +++ b/util/scripts/update_submodules @@ -132,7 +132,7 @@ main() { cd "${TOP}" || exit 1 git add "${submodule}" > /dev/null 2>&1 || exit 1 git commit -s -F- > /dev/null 2>&1 <<-EOF - Update ${submodule##*/} submodule to upstream ${branch##*/} + Update ${submodule##*/} submodule to upstream ${branch_name##*/} Updating from commit id ${initial_commit_id}: $initial_commit_description