From 79f60c6b22c0c6dc578b092fa6e02c9d783bcec2 Mon Sep 17 00:00:00 2001 From: Kun Liu Date: Mon, 23 Dec 2024 17:02:08 +0800 Subject: [PATCH] mb/google/nissa/var/telith: Disable stylus function Disable stylus function based on hardware schematic diagram.Because the external environment is floating, EE requires setting GPIO output to be pulled high or low. BUG=b:372506691 TEST=Local build successfully. Change-Id: I7b72284ab173633405d5de9541f0ea7520d09658 Signed-off-by: Kun Liu Reviewed-on: https://review.coreboot.org/c/coreboot/+/85738 Reviewed-by: Subrata Banik Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) Reviewed-by: Rui Zhou Reviewed-by: Kapil Porwal --- src/mainboard/google/brya/variants/telith/gpio.c | 6 ++++-- .../google/brya/variants/telith/overridetree.cb | 12 ------------ 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/src/mainboard/google/brya/variants/telith/gpio.c b/src/mainboard/google/brya/variants/telith/gpio.c index 7570d51ca3..0043111d74 100644 --- a/src/mainboard/google/brya/variants/telith/gpio.c +++ b/src/mainboard/google/brya/variants/telith/gpio.c @@ -42,8 +42,10 @@ static const struct pad_config override_gpio_table[] = { /* F6 : CNV_PA_BLANKING ==> NC */ PAD_NC(GPP_F6, NONE), - /* F15 : GSXSRESET# ==> SOC_PEN_DETECT_ODL */ - PAD_CFG_GPI_SCI_HIGH(GPP_F15, NONE, PLTRST, EDGE_BOTH), + /* F15 : GSXSRESET# ==> GPIO */ + PAD_CFG_GPO(GPP_F15, 0, DEEP), + /* F13 : GSXSLOAD ==> GPIO */ + PAD_CFG_GPO(GPP_F13, 0, DEEP), /* F18 : THC1_SPI2_INT# ==> NC */ PAD_NC(GPP_F18, NONE), /* F23 : V1P05_CTRL ==> NC*/ diff --git a/src/mainboard/google/brya/variants/telith/overridetree.cb b/src/mainboard/google/brya/variants/telith/overridetree.cb index b48d8a657f..1d6cd4576f 100644 --- a/src/mainboard/google/brya/variants/telith/overridetree.cb +++ b/src/mainboard/google/brya/variants/telith/overridetree.cb @@ -388,18 +388,6 @@ chip soc/intel/alderlake register "has_power_resource" = "1" device i2c 10 on end end - chip drivers/generic/gpio_keys - register "name" = ""PENH"" - register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_F13)" - register "key.wake_gpe" = "GPE0_DW2_15" - register "key.wakeup_route" = "WAKEUP_ROUTE_SCI" - register "key.wakeup_event_action" = "EV_ACT_ANY" - register "key.dev_name" = ""EJCT"" - register "key.linux_code" = "SW_PEN_INSERTED" - register "key.linux_input_type" = "EV_SW" - register "key.label" = ""pen_eject"" - device generic 0 on end - end end device ref i2c2 on chip drivers/intel/mipi_camera