From 79c98cca80cbd875ba2dd55f6a45543a8dbe0cb4 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Fri, 14 Apr 2023 13:43:27 -0500 Subject: [PATCH] mb/google/volteer: Add non-ChromeOS TBMC support for 360/flip variants The TBMC ACPI device is used by Windows ChromeEC drivers to determine tablet mode and to enable motion sensors (accelerometer, gyroscope). Since it's not needed/used by ChromeOS, restrict its inclusion to non-ChromeOS builds. TEST=build/boot Win11/Linux on eldrid, verify tablet mode and rotation work properly, keyboard/touchpad disabled in tablet mode. Change-Id: I65832388649daceb498c91e6405d2b8343ca2aeb Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/91801 Tested-by: build bot (Jenkins) Reviewed-by: Eric Lai --- .../google/volteer/variants/collis/include/variant/ec.h | 5 +++++ .../google/volteer/variants/copano/include/variant/ec.h | 5 +++++ .../google/volteer/variants/delbin/include/variant/ec.h | 5 +++++ .../google/volteer/variants/eldrid/include/variant/ec.h | 5 +++++ .../google/volteer/variants/voema/include/variant/ec.h | 5 +++++ .../google/volteer/variants/voxel/include/variant/ec.h | 5 +++++ 6 files changed, 30 insertions(+) diff --git a/src/mainboard/google/volteer/variants/collis/include/variant/ec.h b/src/mainboard/google/volteer/variants/collis/include/variant/ec.h index 7a2a6ff8b7..dac67ca295 100644 --- a/src/mainboard/google/volteer/variants/collis/include/variant/ec.h +++ b/src/mainboard/google/volteer/variants/collis/include/variant/ec.h @@ -5,4 +5,9 @@ #include +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif diff --git a/src/mainboard/google/volteer/variants/copano/include/variant/ec.h b/src/mainboard/google/volteer/variants/copano/include/variant/ec.h index 7a2a6ff8b7..dac67ca295 100644 --- a/src/mainboard/google/volteer/variants/copano/include/variant/ec.h +++ b/src/mainboard/google/volteer/variants/copano/include/variant/ec.h @@ -5,4 +5,9 @@ #include +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif diff --git a/src/mainboard/google/volteer/variants/delbin/include/variant/ec.h b/src/mainboard/google/volteer/variants/delbin/include/variant/ec.h index 7a2a6ff8b7..dac67ca295 100644 --- a/src/mainboard/google/volteer/variants/delbin/include/variant/ec.h +++ b/src/mainboard/google/volteer/variants/delbin/include/variant/ec.h @@ -5,4 +5,9 @@ #include +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif diff --git a/src/mainboard/google/volteer/variants/eldrid/include/variant/ec.h b/src/mainboard/google/volteer/variants/eldrid/include/variant/ec.h index 7a2a6ff8b7..dac67ca295 100644 --- a/src/mainboard/google/volteer/variants/eldrid/include/variant/ec.h +++ b/src/mainboard/google/volteer/variants/eldrid/include/variant/ec.h @@ -5,4 +5,9 @@ #include +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif diff --git a/src/mainboard/google/volteer/variants/voema/include/variant/ec.h b/src/mainboard/google/volteer/variants/voema/include/variant/ec.h index 7a2a6ff8b7..dac67ca295 100644 --- a/src/mainboard/google/volteer/variants/voema/include/variant/ec.h +++ b/src/mainboard/google/volteer/variants/voema/include/variant/ec.h @@ -5,4 +5,9 @@ #include +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif diff --git a/src/mainboard/google/volteer/variants/voxel/include/variant/ec.h b/src/mainboard/google/volteer/variants/voxel/include/variant/ec.h index 4a9a461191..3e5ff526b5 100644 --- a/src/mainboard/google/volteer/variants/voxel/include/variant/ec.h +++ b/src/mainboard/google/volteer/variants/voxel/include/variant/ec.h @@ -5,4 +5,9 @@ #include +/* Enable Tablet switch for Windows drivers */ +#if !CONFIG(CHROMEOS) +#define EC_ENABLE_TBMC_DEVICE +#endif + #endif