From 78c9f0e96d8173f691cbf2580afb0d8e85d223ba Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 5 Feb 2025 20:17:54 +0000 Subject: [PATCH] mb/starlabs/starbook/adl: Remove OverCurrent config The schematics show that these are not connected, so disconnect the GPIOs and set the ports to OC_SKIP. Change-Id: I9e2b087b348fbae12edaf085fb61776277514c93 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/86288 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/mainboard/starlabs/starbook/variants/adl/devicetree.cb | 6 +++--- src/mainboard/starlabs/starbook/variants/adl/gpio.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index 341ea4075b..217c375148 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -39,12 +39,12 @@ chip soc/intel/alderlake device ref gna on end device ref xhci on # Motherboard USB 3.0 Type-C - register "usb2_ports[0]" = "USB2_PORT_MID(OC5)" - register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC3)" + register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" + register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Motherboard USB 3.0 Type-A register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" - register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC5)" + register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC_SKIP)" # Daughterboard USB 3.0 Type-A register "usb2_ports[6]" = "USB2_PORT_MID(OC0)" diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index 0d15429184..0e71085278 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -69,7 +69,7 @@ const struct pad_config gpio_table[] = { /* A15: Test Point 52 */ PAD_NC(GPP_A15, NONE), /* A16: USB OverCurrent 3 */ - PAD_CFG_NF(GPP_A16, NONE, DEEP, NF1), + PAD_NC(GPP_A16, NONE), /* A17: Not Connected */ PAD_NC(GPP_A17, NONE), /* A18: DDI B DP HPD */ @@ -257,7 +257,7 @@ const struct pad_config gpio_table[] = { /* E8: DRAM Sleep */ PAD_CFG_NF(GPP_E8, NONE, DEEP, NF1), /* E9: USB OverCurrent 0 */ - PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), + PAD_NC(GPP_E9, NONE), /* E10: PWD Amplifier Input */ PAD_NC(GPP_E10, NONE), /* E11: TPM IRQ */