From 7896f4950cd760778aae735871c7a0126824c122 Mon Sep 17 00:00:00 2001 From: Vince Liu Date: Wed, 27 Aug 2025 15:31:50 +0800 Subject: [PATCH] mb/google/skywalker: Turn off UFS power for eMMC SKUs On MT8189, UFS power is enabled by default. For SKUs that use eMMC for storage and do not need UFS, it is necessary to disable UFS power; otherwise, the system will fail to suspend properly. Disabling UFS power in these cases both saves power and ensures correct suspend functionality. BUG=b:430421429 BRANCH=skywalker TEST=Suspend flow works correctly, and SoC power consumption is 34 mW, meeting expectations on Anakin. Signed-off-by: Vince Liu Change-Id: Ie932a939f663e159e098fd13c7e26e9a2089e7bd Reviewed-on: https://review.coreboot.org/c/coreboot/+/88977 Reviewed-by: Yu-Ping Wu Reviewed-by: Yidi Lin Tested-by: build bot (Jenkins) --- src/mainboard/google/skywalker/mainboard.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/skywalker/mainboard.c b/src/mainboard/google/skywalker/mainboard.c index fb5316201a..ba6b66fd18 100644 --- a/src/mainboard/google/skywalker/mainboard.c +++ b/src/mainboard/google/skywalker/mainboard.c @@ -88,8 +88,10 @@ enum mtk_storage_type mainboard_get_storage_type(void) static void mainboard_init(struct device *dev) { - if (mainboard_get_storage_type() == STORAGE_EMMC) + if (mainboard_get_storage_type() == STORAGE_EMMC) { mtk_msdc_configure_emmc(true); + mtcmos_ufs_power_off(); + } dpm_init(); setup_usb_host();