From 77c610464548ded89bdf73c8a7cc7c6c78cbc63f Mon Sep 17 00:00:00 2001 From: Momoko Hattori Date: Wed, 28 May 2025 23:46:03 +0900 Subject: [PATCH] Revert "mb/google/rex: Enable use_gpio_for_status for touchscreen" This reverts commit 81f396ec2faefeda33b7e23d9cef380fce11a22c. Reason for revert: Reported to have broken touchscreen for screebo. BUG=b:420550351 BUG=b:397355818 TEST=FW_NAME=screebo cros build-packages --board=rex chromeos-bootimage TEST=FW_NAME=karis cros build-packages --board=rex chromeos-bootimage TEST=karis boots successfully and touchscreen remains to work. Change-Id: I75dad8cd07c900f963888b0a34bf18d893f20d71 Signed-off-by: Momoko Hattori Reviewed-on: https://review.coreboot.org/c/coreboot/+/87893 Reviewed-by: YH Lin Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) --- src/mainboard/google/rex/variants/kanix/overridetree.cb | 1 - src/mainboard/google/rex/variants/karis/overridetree.cb | 1 - src/mainboard/google/rex/variants/rex0/overridetree.cb | 1 - src/mainboard/google/rex/variants/screebo/overridetree.cb | 2 -- 4 files changed, 5 deletions(-) diff --git a/src/mainboard/google/rex/variants/kanix/overridetree.cb b/src/mainboard/google/rex/variants/kanix/overridetree.cb index 31fbf555a6..f0d57b3046 100644 --- a/src/mainboard/google/rex/variants/kanix/overridetree.cb +++ b/src/mainboard/google/rex/variants/kanix/overridetree.cb @@ -459,7 +459,6 @@ chip soc/intel/meteorlake register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C06)" register "generic.stop_off_delay_ms" = "1" register "generic.has_power_resource" = "1" - register "generic.use_gpio_for_status" = "true" register "hid_desc_reg_offset" = "0x01" device i2c 0x10 on end end diff --git a/src/mainboard/google/rex/variants/karis/overridetree.cb b/src/mainboard/google/rex/variants/karis/overridetree.cb index 2607ad776f..ea45d61981 100644 --- a/src/mainboard/google/rex/variants/karis/overridetree.cb +++ b/src/mainboard/google/rex/variants/karis/overridetree.cb @@ -404,7 +404,6 @@ chip soc/intel/meteorlake register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C06)" register "generic.stop_off_delay_ms" = "1" register "generic.has_power_resource" = "1" - register "generic.use_gpio_for_status" = "true" register "hid_desc_reg_offset" = "0x01" device i2c 0x10 on end end diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index 177e88781c..66b2bc9528 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -579,7 +579,6 @@ chip soc/intel/meteorlake register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C06)" register "generic.stop_off_delay_ms" = "2" register "generic.has_power_resource" = "1" - register "generic.use_gpio_for_status" = "true" register "hid_desc_reg_offset" = "0x01" device i2c 10 on probe TOUCHSCREEN TOUCHSCREEN_I2C diff --git a/src/mainboard/google/rex/variants/screebo/overridetree.cb b/src/mainboard/google/rex/variants/screebo/overridetree.cb index 6e8f5fc028..d46d7c91ef 100644 --- a/src/mainboard/google/rex/variants/screebo/overridetree.cb +++ b/src/mainboard/google/rex/variants/screebo/overridetree.cb @@ -451,7 +451,6 @@ chip soc/intel/meteorlake register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B17)" register "generic.enable_delay_ms" = "12" register "generic.has_power_resource" = "1" - register "generic.use_gpio_for_status" = "true" register "hid_desc_reg_offset" = "0x01" device i2c 41 on probe TOUCHSCREEN TOUCHSCREEN_ILITEK @@ -468,7 +467,6 @@ chip soc/intel/meteorlake register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B17)" register "generic.enable_delay_ms" = "1" register "generic.has_power_resource" = "1" - register "generic.use_gpio_for_status" = "true" register "hid_desc_reg_offset" = "0x01" device i2c 10 on probe TOUCHSCREEN TOUCHSCREEN_ELAN