From 7719ac411bbae59463a72504604bb7973e15a3d6 Mon Sep 17 00:00:00 2001 From: Douglas Anderson Date: Tue, 27 Oct 2015 16:23:39 -0700 Subject: [PATCH] rk3288: Fix HDMI soft reset HDMI soft reset happens when you write 0, not 1. ...not that I've ever seen the soft reset do something, but if we're going to try it we should probably try to do it correctly. BRANCH=none BUG=chrome-os-partner:46256 TEST=Doesn't break anything Change-Id: I0f4ab869b1e1a2d4a38f0eacfd01b01760069f58 Signed-off-by: Douglas Anderson Reviewed-on: https://chromium-review.googlesource.com/309317 Reviewed-by: David Hendricks Reviewed-by: Yakir Yang Reviewed-by: Julius Werner Commit-Queue: Julius Werner Tested-by: Julius Werner Reviewed-by: Agnes Cheng Commit-Queue: Agnes Cheng Trybot-Ready: Agnes Cheng Tested-by: Agnes Cheng --- src/soc/rockchip/rk3288/hdmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/soc/rockchip/rk3288/hdmi.c b/src/soc/rockchip/rk3288/hdmi.c index 639f733266..d9a8378c95 100644 --- a/src/soc/rockchip/rk3288/hdmi.c +++ b/src/soc/rockchip/rk3288/hdmi.c @@ -717,8 +717,7 @@ static int hdmi_ddc_wait_i2c_done(int msec) static void hdmi_ddc_reset(void) { - clrsetbits_le32(&hdmi_regs->i2cm_softrstz, HDMI_I2CM_SOFTRSTZ, - HDMI_I2CM_SOFTRSTZ); + clrbits_le32(&hdmi_regs->i2cm_softrstz, HDMI_I2CM_SOFTRSTZ); } static int hdmi_read_edid(int block, u8 *buff)