From 76a1e81b103161da28e0cb6f19984250239be967 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Fri, 18 Apr 2025 19:42:14 +0100 Subject: [PATCH] mb/starlabs/*: Unify Sleep S3 and S4 GPIO configurations Ensure all boards configure these two GPIOs to NF1. Change-Id: Ie8a222bff349a427083adb1c4d7ca73a41de3095 Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/87360 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c | 4 ++-- src/mainboard/starlabs/starbook/variants/adl/gpio.c | 4 ++-- src/mainboard/starlabs/starbook/variants/rpl/gpio.c | 4 ++-- src/mainboard/starlabs/starfighter/variants/rpl/gpio.c | 4 ++-- src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index 242124c415..6b9fb5be6e 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -21,8 +21,8 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ - PAD_NC(GPD4, NONE), /* Sleep S3 */ - PAD_NC(GPD5, NONE), /* Sleep S4 */ + PAD_CFG_NF(GPD4, NONE, DEEP, NF1), /* Sleep S3 */ + PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ /* eSPI */ diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index 3ddf06c7fb..7edf4ce7b9 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -21,8 +21,8 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ - PAD_NC(GPD4, NONE), /* Sleep S3 */ - PAD_NC(GPD5, NONE), /* Sleep S4 */ + PAD_CFG_NF(GPD4, NONE, DEEP, NF1), /* Sleep S3 */ + PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ /* eSPI */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 6682a39cd4..56ab332835 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -21,8 +21,8 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ - PAD_NC(GPD4, NONE), /* Sleep S3 */ - PAD_NC(GPD5, NONE), /* Sleep S4 */ + PAD_CFG_NF(GPD4, NONE, DEEP, NF1), /* Sleep S3 */ + PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ /* eSPI */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index c506789ff4..ab97afe180 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -31,8 +31,8 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ - PAD_NC(GPD4, NONE), /* Sleep S3 */ - PAD_NC(GPD5, NONE), /* Sleep S4 */ + PAD_CFG_NF(GPD4, NONE, DEEP, NF1), /* Sleep S3 */ + PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ /* eSPI */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index 2b0e710d29..40cdafa3aa 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -21,8 +21,8 @@ const struct pad_config gpio_table[] = { PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ - PAD_NC(GPD4, NONE), /* Sleep S3 */ - PAD_NC(GPD5, NONE), /* Sleep S4 */ + PAD_CFG_NF(GPD4, NONE, DEEP, NF1), /* Sleep S3 */ + PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* Sleep S4 */ PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ /* eSPI */