erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UPSTREAM: src/include: Move storage class to beginning of declaration

Browse source 
Fix the following warning detected by checkpatch.pl:

WARNING: storage class should be at the beginning of the declaration

The following storage class attribute is not detected by checkpatch.py:

        static cbmem_init_hook_t init_fn_ ## _ptr_ __attribute__((used,
\
        section(".rodata.cbmem_init_hooks"))) = init_fn_;

The following lines generates a false positive:

(pound)define STATIC static
src/include/cpu/amd/common/cbtypes.h:60: WARNING: storage class should
be at the beginning of the declaration

typedef asmlinkage void (*smm_handler_t)(void *);
src/include/cpu/x86/smm.h:514: WARNING: storage class should be at the
beginning of the declaration

(pound)define MAYBE_STATIC static
src/include/stddef.h:34: WARNING: storage class should be at the
beginning of the declaration

TEST=Build and run on Galileo Gen2

Change-Id: I165a7e83519a6738460dbd3764b2c2dfad2bb4dd
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 22c28e0f6a
Original-Change-Id: Ie087d38e6171b549b90e0b831050ac44746a1e14
Original-Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Original-Reviewed-on: https://review.coreboot.org/18657
Original-Tested-by: build bot (Jenkins)
Original-Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://chromium-review.googlesource.com/454547
This commit is contained in:
Lee Leahy 2017-03-07 15:47:44 -08:00 • committed by chrome-bot
commit 751135d132
6 changed files with 24 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/include/cpu/cpu.h
View file

@ -7,7 +7,7 @@
void cpu_initialize(unsigned int cpu_index);
struct bus;
void initialize_cpus(struct bus *cpu_bus);
void asmlinkage secondary_cpu_init(unsigned int cpu_index);
asmlinkage void secondary_cpu_init(unsigned int cpu_index);
int cpu_phys_address_size(void);
#define __cpu_driver __attribute__ ((used, __section__(".rodata.cpu_driver")))

2
src/include/cpu/intel/romstage.h
View file

@ -27,6 +27,6 @@ void *setup_stack_and_mtrrs(void);
asmlinkage void *romstage_main(unsigned long bist);
/* romstage_after_car() is the C function called after cache-as-ram has
* been torn down. It is responsible for loading the ramstage. */
void asmlinkage romstage_after_car(void);
asmlinkage void romstage_after_car(void);
#endif /* _CPU_INTEL_ROMSTAGE_H */

2
src/include/cpu/x86/smm.h
View file

@ -517,7 +517,7 @@ typedef asmlinkage void (*smm_handler_t)(void *);
/* SMM Runtime helpers. */
/* Entry point for SMM modules. */
void asmlinkage smm_handler_start(void *params);
asmlinkage void smm_handler_start(void *params);
/* Retrieve SMM save state for a given CPU. WARNING: This does not take into
* account CPUs which are configured to not save their state to RAM. */