From 73a36696f070d1a012c14f8367733dda9f3a3d9e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonathan=20Neusch=C3=A4fer?= Date: Sat, 12 Nov 2016 13:50:17 +0100 Subject: [PATCH] UPSTREAM: soc/marvell/mvmap2315: Fix integer arithmetic Replace logical with bitwise AND operator. BUG=None BRANCH=None TEST=None Reported-by: Coverity (CID 1362808) Signed-off-by: Jonathan Neuschfer Reviewed-on: https://review.coreboot.org/17401 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Nico Huber Reviewed-by: Ronald G. Minnich Change-Id: I712fab61fbbc833fc2b2575948a875e2f07fd5de Reviewed-on: https://chromium-review.googlesource.com/417073 Commit-Ready: Furquan Shaikh Tested-by: Furquan Shaikh Reviewed-by: Aaron Durbin --- src/soc/marvell/mvmap2315/mcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/marvell/mvmap2315/mcu.c b/src/soc/marvell/mvmap2315/mcu.c index c334cda145..e634ff8d56 100644 --- a/src/soc/marvell/mvmap2315/mcu.c +++ b/src/soc/marvell/mvmap2315/mcu.c @@ -31,7 +31,7 @@ static u8 mvmap2315_calc_checksum(const void *data, u32 size) for (i = csum = 0; i < size; i++) csum += bytes[i]; - return (~csum) && 0xFF; + return (~csum) & 0xFF; } void mcu_irq(void)