erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

lib/edid_fill_fb: Support multiple framebuffers

Browse source 
Currently it's not possible to add multiple graphics driver into
one coreboot image. This patch series will fix this issue by providing
a single API that multiple graphics driver can use.

This is required for platforms that have two graphic cards, but
different graphic drivers, like Intel and Aspeed on server platforms or
Intel and Nvidia on consumer notebooks.

The goals are to remove duplicated fill_fb_framebuffer(), to advertise
multiple independent framebuffers in coreboot tables, and better
runtime/build time graphic configuration options.

Add an implementation in edid_fill_fb that supports registering
multiple framebuffers, each with its own configuration.

As the current code is only compiled for a single graphics driver
there's no change in functionality.

Change-Id: I7264c2ea2f72f36adfd26f26b00e3ce172133621
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39002
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Patrick Rudolph 2020-02-19 12:10:51 +01:00 • committed by Angel Pons
commit 73192888b4
4 changed files with 174 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/include/edid.h
View file

@ -4,6 +4,7 @@
#define EDID_H
#include <stdint.h>
#include <framebuffer_info.h>
#include "commonlib/coreboot_tables.h"
enum edid_modes {
@ -95,7 +96,7 @@ enum edid_status {
int decode_edid(unsigned char *edid, int size, struct edid *out);
void edid_set_framebuffer_bits_per_pixel(struct edid *edid, int fb_bpp,
int row_byte_alignment);
void set_vbe_mode_info_valid(const struct edid *edid, uintptr_t fb_addr);
struct fb_info *set_vbe_mode_info_valid(const struct edid *edid, uintptr_t fb_addr);
void set_vbe_framebuffer_orientation(enum lb_fb_orientation orientation);
int set_display_mode(struct edid *edid, enum edid_modes mode);

22
src/include/framebuffer_info.h Normal file
View file

@ -0,0 +1,22 @@
/* SPDX-License-Identifier: GPL-2.0-or-later */
#ifndef __FRAMEBUFFER_INFO_H_
#define __FRAMEBUFFER_INFO_H_
#include <stdint.h>
#include <stdbool.h>
#include <commonlib/coreboot_tables.h>
struct fb_info;
struct fb_info *
fb_add_framebuffer_info_ex(const struct lb_framebuffer *fb);
struct fb_info *fb_add_framebuffer_info(uintptr_t fb_addr, uint32_t x_resolution,
uint32_t y_resolution, uint32_t bytes_per_line,
uint8_t bits_per_pixel);
void fb_set_orientation(struct fb_info *info,
enum lb_fb_orientation orientation);
#endif /* __FRAMEBUFFER_INFO_H_ */