From 721fc2361ea9c6fea75409be57726294ce840f03 Mon Sep 17 00:00:00 2001 From: Stefan Reinauer Date: Mon, 3 Mar 2014 15:08:10 -0800 Subject: [PATCH] google/panther: Be safe about invalid thermal readings In case we get an invalid thermal reading, let's run the fan at full speed rather than at low speed. This might impact the user experiance slightly in cases where the bad reading does not happen while the system is hot, but it will increase stability in the cases where the system is actually overheating. Also, set the critical temperature below tjmax, because otherwise thermal shutdown by the OS will never be triggered. Signed-off-by: Stefan Reinauer BUG=chrome-os-partner:26045 BRANCH=panther, all haswell designs with ITE superIO TEST=Unable to reproduce bug described in 26045 Change-Id: Iab262f1f17a5dff875c596d9e8d50e4e50ee90f9 Reviewed-on: https://chromium-review.googlesource.com/188556 Reviewed-by: Shawn Nematbakhsh Commit-Queue: Stefan Reinauer Tested-by: Stefan Reinauer --- src/mainboard/google/panther/acpi/thermal.asl | 4 ++-- src/mainboard/google/panther/thermal.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mainboard/google/panther/acpi/thermal.asl b/src/mainboard/google/panther/acpi/thermal.asl index d4f030a6ab..9486d3ccf2 100644 --- a/src/mainboard/google/panther/acpi/thermal.asl +++ b/src/mainboard/google/panther/acpi/thermal.asl @@ -76,12 +76,12 @@ Scope (\_TZ) // Check for "no reading available If (LEqual (Local0, 0x80)) { - Return (CTOK (\F2ON)) + Return (CTOK (\F0ON)) } // Check for invalid readings If (LOr (LEqual (Local0, 255), LEqual (Local0, 0))) { - Return (CTOK (\F2ON)) + Return (CTOK (\F0ON)) } // PECI raw value is an offset from Tj_max diff --git a/src/mainboard/google/panther/thermal.h b/src/mainboard/google/panther/thermal.h index 2d345c0fb2..7a9656143d 100644 --- a/src/mainboard/google/panther/thermal.h +++ b/src/mainboard/google/panther/thermal.h @@ -46,7 +46,7 @@ #define FAN0_PWM 0xff /* Temperature which OS will shutdown at */ -#define CRITICAL_TEMPERATURE 100 +#define CRITICAL_TEMPERATURE 98 /* Temperature which OS will throttle CPU */ #define PASSIVE_TEMPERATURE 90