erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

veyron_pinky: Add board ID support

Browse source 
This patch adds code to read the board ID from Pinky and put it into the
coreboot table.

(Note: This implementation differs slightly from Tegra since it pinmuxes
the GPIOs inside board_id(). That means the pinmuxing might be set more
than once if called in multiple stages, which is perfectly harmless and
in my opinion cleaner than having to (remember to) do it manually in one
of the per-stage files.)

BUG=chrome-os-partner:30167
TEST=With depthcharge patch, select -rev1 device tree for board ID 0.

Change-Id: I265fafcb176a31a46f7792ecf352f1671be7dd41
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 9da10ce8b6
Original-Change-Id: I5b5689373e1e47b1e0944b5fe5f2e70a285b931f
Original-Signed-off-by: Julius Werner <jwerner@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/217675
Original-Reviewed-by: David Hendricks <dhendrix@chromium.org>
Reviewed-on: http://review.coreboot.org/8870
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins)
This commit is contained in:
Julius Werner 2014-09-10 15:30:49 -07:00 • committed by Patrick Georgi
commit 72001e79e9
3 changed files with 51 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/mainboard/google/veyron_pinky/Kconfig
View file

@ -21,6 +21,7 @@ if BOARD_GOOGLE_VEYRON_PINKY
config BOARD_SPECIFIC_OPTIONS # dummy
def_bool y
select BOARD_ID_SUPPORT
select CHROMEOS
select EC_GOOGLE_CHROMEEC
select EC_GOOGLE_CHROMEEC_SPI

3
src/mainboard/google/veyron_pinky/Makefile.inc
View file

@ -20,8 +20,9 @@
romstage-y += romstage.c
romstage-y += chromeos.c
romstage-y += sdram_configs.c
ramstage-y += boardid.c
ramstage-y += chromeos.c
ramstage-y += mainboard.c
ramstage-y += chromeos.c
ramstage-y += pmic.c

48
src/mainboard/google/veyron_pinky/boardid.c Normal file
View file

@ -0,0 +1,48 @@
/*
* This file is part of the coreboot project.
*
* Copyright 2014 Google Inc.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
#include <stdlib.h>
#include <console/console.h>
#include <soc/rockchip/rk3288/gpio.h>
#include <boardid.h>
uint8_t board_id(void)
{
static int id = -1;
static const gpio_t pins[] = {
{ .port = 2, .bank = GPIO_A, .idx = 0 },
{ .port = 2, .bank = GPIO_A, .idx = 1 },
{ .port = 2, .bank = GPIO_A, .idx = 2 },
{ .port = 2, .bank = GPIO_A, .idx = 7 },
};
if (id < 0) {
int i;
id = 0;
for (i = 0; i < ARRAY_SIZE(pins); i++) {
gpio_input(pins[i]);
id |= gpio_get_in_value(pins[i]) << i;
}
printk(BIOS_SPEW, "Board ID: %#x.\n", id);
}
return id;
}