From 6ffbc9a929550d7861d0f5aa4f9b9734c1f7b1df Mon Sep 17 00:00:00 2001 From: Vince Liu Date: Fri, 17 Oct 2025 11:03:56 +0800 Subject: [PATCH] soc/mediatek: Move mtk_dsi_reset() to mtk_dsi_common.c for reuse Move mtk_dsi_reset() from mtk_mipi_dphy.c to mtk_dsi_common.c so that it can also be used when using the C-PHY interface, improving code reuse. BUG=b:433422905,b:428854543 BRANCH=skywaler TEST=build passed Signed-off-by: Vince Liu Change-Id: I3f080127af4411584f66e307f7d2b13abbb051bf Reviewed-on: https://review.coreboot.org/c/coreboot/+/89619 Reviewed-by: Yidi Lin Tested-by: build bot (Jenkins) Reviewed-by: Yu-Ping Wu --- src/soc/mediatek/common/mtk_dsi_common.c | 12 ++++++++++++ src/soc/mediatek/common/mtk_mipi_dphy.c | 8 -------- src/soc/mediatek/mt8183/Makefile.mk | 1 + src/soc/mediatek/mt8186/Makefile.mk | 1 + src/soc/mediatek/mt8188/Makefile.mk | 1 + src/soc/mediatek/mt8192/Makefile.mk | 1 + 6 files changed, 16 insertions(+), 8 deletions(-) create mode 100644 src/soc/mediatek/common/mtk_dsi_common.c diff --git a/src/soc/mediatek/common/mtk_dsi_common.c b/src/soc/mediatek/common/mtk_dsi_common.c new file mode 100644 index 0000000000..67654b1630 --- /dev/null +++ b/src/soc/mediatek/common/mtk_dsi_common.c @@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ + +#include +#include + +void mtk_dsi_reset(void) +{ + write32(&dsi0->dsi_force_commit, + DSI_FORCE_COMMIT_USE_MMSYS | DSI_FORCE_COMMIT_ALWAYS); + write32(&dsi0->dsi_con_ctrl, 1); + write32(&dsi0->dsi_con_ctrl, 0); +} diff --git a/src/soc/mediatek/common/mtk_mipi_dphy.c b/src/soc/mediatek/common/mtk_mipi_dphy.c index fa73ddb4e6..d50a7898be 100644 --- a/src/soc/mediatek/common/mtk_mipi_dphy.c +++ b/src/soc/mediatek/common/mtk_mipi_dphy.c @@ -61,11 +61,3 @@ void mtk_dsi_configure_mipi_tx(u32 data_rate, u32 lanes) setbits32(&mipi_tx->ck_ckmode_en, DSI_CK_CKMODE_EN); } - -void mtk_dsi_reset(void) -{ - write32(&dsi0->dsi_force_commit, - DSI_FORCE_COMMIT_USE_MMSYS | DSI_FORCE_COMMIT_ALWAYS); - write32(&dsi0->dsi_con_ctrl, 1); - write32(&dsi0->dsi_con_ctrl, 0); -} diff --git a/src/soc/mediatek/mt8183/Makefile.mk b/src/soc/mediatek/mt8183/Makefile.mk index c1fd3b8a7a..a4aa9db0ea 100644 --- a/src/soc/mediatek/mt8183/Makefile.mk +++ b/src/soc/mediatek/mt8183/Makefile.mk @@ -55,6 +55,7 @@ ramstage-y += ../common/i2c.c i2c.c ramstage-y += ../common/mcu.c ramstage-y += ../common/mmu_operations.c mmu_operations.c ramstage-y += ../common/mtcmos.c mtcmos.c +ramstage-y += ../common/mtk_dsi_common.c ramstage-y += ../common/pmic_wrap.c ramstage-y += ../common/rtc.c ../common/rtc_pwrap_ops.c ../common/rtc_osc_init.c rtc.c ramstage-y += soc.c diff --git a/src/soc/mediatek/mt8186/Makefile.mk b/src/soc/mediatek/mt8186/Makefile.mk index 080cc1337f..6625988edd 100644 --- a/src/soc/mediatek/mt8186/Makefile.mk +++ b/src/soc/mediatek/mt8186/Makefile.mk @@ -47,6 +47,7 @@ ramstage-y += ../common/mcu.c ramstage-y += ../common/mmu_operations.c ramstage-$(CONFIG_COMMONLIB_STORAGE_MMC) += ../common/msdc.c msdc.c ramstage-y += ../common/mtcmos.c mtcmos.c +ramstage-y += ../common/mtk_dsi_common.c ramstage-y += ../common/pmic_wrap.c pmic_wrap.c pmif.c mt6366.c ramstage-y += ../common/rtc.c ../common/rtc_pwrap_ops.c ../common/rtc_osc_init.c rtc.c ramstage-y += soc.c diff --git a/src/soc/mediatek/mt8188/Makefile.mk b/src/soc/mediatek/mt8188/Makefile.mk index f8a7faa577..fa9a8f119a 100644 --- a/src/soc/mediatek/mt8188/Makefile.mk +++ b/src/soc/mediatek/mt8188/Makefile.mk @@ -54,6 +54,7 @@ ramstage-y += ../common/mmu_operations.c ramstage-$(CONFIG_COMMONLIB_STORAGE_MMC) += ../common/msdc.c msdc.c ramstage-y += ../common/mt6359p.c mt6359p.c ramstage-y += ../common/mtcmos.c mtcmos.c +ramstage-y += ../common/mtk_dsi_common.c ramstage-y += ../common/pmif.c ../common/pmif_clk.c ../common/pmif_init.c pmif_clk.c ramstage-y += ../common/pmif_spi.c pmif_spi.c ramstage-y += ../common/pmif_spmi.c ../common/pmif_spmi_v1.c pmif_spmi.c diff --git a/src/soc/mediatek/mt8192/Makefile.mk b/src/soc/mediatek/mt8192/Makefile.mk index ae75f13eb2..eaf7bc1856 100644 --- a/src/soc/mediatek/mt8192/Makefile.mk +++ b/src/soc/mediatek/mt8192/Makefile.mk @@ -47,6 +47,7 @@ ramstage-y += ../common/mcupm.c ramstage-y += ../common/mmu_operations.c ramstage-$(CONFIG_COMMONLIB_STORAGE_MMC) += ../common/msdc.c msdc.c ramstage-y += ../common/mtcmos.c mtcmos.c +ramstage-y += ../common/mtk_dsi_common.c ramstage-y += ../common/pmif.c ../common/pmif_init.c ramstage-y += ../common/rtc.c ../common/rtc_mt6359p.c ramstage-y += soc.c