From 6f11c313546810989a950a0cc15f75ec11a46a69 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Thu, 4 Sep 2025 10:55:45 -0500 Subject: [PATCH] mb/starlabs/starbook/mtl: Update HDA verb table Remove presence detection flag for the DMIC and internal speakers. Update the subsystem ID to match that used by the AMI UEFI Firmware. While we're at it, fix the (non-functional) descriptive flags for those two verbs as well. Remove unnecessary line continuations. TEST=build/boot Win11 and Linux on Starbook MTL, verify speaker and intermal mic working, as well as headphones/jack mic when plugged in. Change-Id: I7621a6b57fb525892e84d06470eab5a9bdd32065 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/89042 Reviewed-by: Sean Rhodes Tested-by: build bot (Jenkins) --- .../starbook/variants/mtl/devicetree.cb | 2 +- .../starlabs/starbook/variants/mtl/hda_verb.c | 76 +++++++++---------- 2 files changed, 39 insertions(+), 39 deletions(-) diff --git a/src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb index dbb7dca439..2865a3d4b1 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb @@ -280,7 +280,7 @@ chip soc/intel/meteorlake end end device ref hda on - subsystemid 0x1e50 0x7038 + subsystemid 0x1025 0x174e register "pch_hda_sdi_enable[0]" = "true" register "pch_hda_dsp_enable" = "true" register "pch_hda_audio_link_hda_enable" = "true" diff --git a/src/mainboard/starlabs/starbook/variants/mtl/hda_verb.c b/src/mainboard/starlabs/starbook/variants/mtl/hda_verb.c index 89de21c1d4..eb16aaf3e9 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/hda_verb.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/hda_verb.c @@ -17,57 +17,57 @@ const u32 cim_verb_data[] = { /* coreboot specific header */ 0x10ec0269, /* Codec Vendor / Device ID: Realtek ALC269 */ - 0x1e507038, /* Subsystem ID */ + 0x1025174e, /* Subsystem ID */ 18, /* Number of verb entries */ /* Reset Codec First */ AZALIA_RESET(0x1), /* HDA Codec Subsystem ID */ - AZALIA_SUBVENDOR(0, 0x1e507038), + AZALIA_SUBVENDOR(0, 0x1025174e), AZALIA_PIN_CFG(0, 0x01, 0x00000000), - AZALIA_PIN_CFG(0, DMIC, AZALIA_PIN_DESC( \ - AZALIA_INTEGRATED, \ - AZALIA_INTERNAL | AZALIA_TOP, \ - AZALIA_MIC_IN, \ - AZALIA_TYPE_UNKNOWN, \ - AZALIA_BLACK, \ - AZALIA_JACK_PRESENCE_DETECT, \ - 3, \ - 0 \ + AZALIA_PIN_CFG(0, DMIC, AZALIA_PIN_DESC( + AZALIA_INTEGRATED, + AZALIA_MOBILE_LID_INSIDE, + AZALIA_MIC_IN, + AZALIA_OTHER_DIGITAL, + AZALIA_COLOR_UNKNOWN, + AZALIA_NO_JACK_PRESENCE_DETECT, + 3, + 0 )), - AZALIA_PIN_CFG(0, SPEAKERS, AZALIA_PIN_DESC( \ - AZALIA_INTEGRATED, \ - AZALIA_INTERNAL | AZALIA_FRONT, \ - AZALIA_SPEAKER, \ - AZALIA_TYPE_UNKNOWN, \ - AZALIA_BLACK, \ - AZALIA_JACK_PRESENCE_DETECT, \ - 1, \ - 0 \ + AZALIA_PIN_CFG(0, SPEAKERS, AZALIA_PIN_DESC( + AZALIA_INTEGRATED, + AZALIA_INTERNAL | AZALIA_TOP, + AZALIA_SPEAKER, + AZALIA_OTHER_ANALOG, + AZALIA_COLOR_UNKNOWN, + AZALIA_NO_JACK_PRESENCE_DETECT, + 1, + 0 )), - AZALIA_PIN_CFG(0, HEADPHONE, AZALIA_PIN_DESC( \ - AZALIA_JACK, \ - AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_RIGHT, \ - AZALIA_HP_OUT, \ - AZALIA_STEREO_MONO_1_8, \ - AZALIA_BLACK, \ - AZALIA_JACK_PRESENCE_DETECT, \ - 2, \ - 0 \ + AZALIA_PIN_CFG(0, HEADPHONE, AZALIA_PIN_DESC( + AZALIA_JACK, + AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_RIGHT, + AZALIA_HP_OUT, + AZALIA_STEREO_MONO_1_8, + AZALIA_BLACK, + AZALIA_JACK_PRESENCE_DETECT, + 2, + 0 )), AZALIA_PIN_CFG(0, MONO, AZALIA_PIN_CFG_NC(0)), - AZALIA_PIN_CFG(0, MIC1, AZALIA_PIN_DESC( \ - AZALIA_JACK, \ - AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_RIGHT, \ - AZALIA_MIC_IN, \ - AZALIA_STEREO_MONO_1_8, \ - AZALIA_BLACK, \ - AZALIA_JACK_PRESENCE_DETECT, \ - 4, \ - 0 \ + AZALIA_PIN_CFG(0, MIC1, AZALIA_PIN_DESC( + AZALIA_JACK, + AZALIA_EXTERNAL_PRIMARY_CHASSIS | AZALIA_RIGHT, + AZALIA_MIC_IN, + AZALIA_STEREO_MONO_1_8, + AZALIA_BLACK, + AZALIA_JACK_PRESENCE_DETECT, + 4, + 0 )), AZALIA_PIN_CFG(0, MIC2, AZALIA_PIN_CFG_NC(0)), AZALIA_PIN_CFG(0, LINE1, AZALIA_PIN_CFG_NC(0)),