erebion/coreboot
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UPSTREAM: mainboard/intel/galileo: Remove use of EDK-II macros & data types

Browse source 
Add assert.h to use coreboot's ASSERT macro.
Replace the use of UINT8 data type with uint8_t.

TEST=Build and run on Galileo Gen2.

BUG=None
BRANCH=None

Change-Id: Ibc0180272cbfd7df4928bd841b02e23562fe1223
Signed-off-by: Lee Leahy <leroy.p.leahy@intel.com>
Reviewed-on: https://review.coreboot.org/15859
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-on: https://chromium-review.googlesource.com/367384
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@chromium.org>
This commit is contained in:
Lee Leahy 2016-07-21 09:28:56 -07:00 • committed by chrome-bot
commit 6e94cdbd09
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/mainboard/intel/galileo/reg_access.c
View file

@ -15,6 +15,7 @@
#define __SIMPLE_DEVICE__
#include <assert.h>
#include <arch/io.h>
#include <console/console.h>
#include <device/i2c.h>
@ -45,7 +46,7 @@ static uint64_t reg_read(struct reg_script_context *ctx)
case GEN2_I2C_LED_PWM:
if (ctx->display_features)
printk(BIOS_INFO, "I2C chip 0x%02x: ", step->id);
ret_code = i2c_readb(0, step->id, (UINT8)step->reg, &value);
ret_code = i2c_readb(0, step->id, (uint8_t)step->reg, &value);
ASSERT(ret_code == 2);
break;
}
@ -76,8 +77,8 @@ static void reg_write(struct reg_script_context *ctx)
case RMU_TEMP_REGS:
if (ctx->display_features)
printk(BIOS_INFO, "I2C chip 0x%02x: ", step->id);
value = (UINT8)step->value;
ret_code = i2c_writeb(0, step->id, (UINT8)step->reg, value);
value = (uint8_t)step->value;
ret_code = i2c_writeb(0, step->id, (uint8_t)step->reg, value);
ASSERT(ret_code == 2);
break;
}